linux-kernel - Re: [PATCH] mfd: ntxec: Add version number for EC in Tolino Vision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9Pg35aH5WL7burc@google.com>
Date:   Fri, 27 Jan 2023 14:34:07 +0000
From:   Lee Jones <lee@...nel.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     j.neuschaefer@....net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: ntxec: Add version number for EC in Tolino Vision

On Tue, 24 Jan 2023, Andreas Kemnade wrote:

> The EC firmware has a different version number than anything
> defined until now.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---
>  drivers/mfd/ntxec.c       | 1 +
>  include/linux/mfd/ntxec.h | 4 ++++
>  2 files changed, 5 insertions(+)
> 
> diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c
> index e16a7a82a929..b02785b10d48 100644
> --- a/drivers/mfd/ntxec.c
> +++ b/drivers/mfd/ntxec.c
> @@ -175,6 +175,7 @@ static int ntxec_probe(struct i2c_client *client)
>  	/* Bail out if we encounter an unknown firmware version */
>  	switch (version) {
>  	case NTXEC_VERSION_KOBO_AURA:
> +	case NTXEC_VERSION_TOLINO_VISION:
>  		subdevs = ntxec_subdev;
>  		n_subdevs = ARRAY_SIZE(ntxec_subdev);
>  		break;
> diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h
> index cc6f07bfa2b3..562895eb9a31 100644
> --- a/include/linux/mfd/ntxec.h
> +++ b/include/linux/mfd/ntxec.h
> @@ -35,4 +35,8 @@ static inline u16 ntxec_reg8(u8 value)
>  #define NTXEC_VERSION_KOBO_AURA	0xd726	/* found in Kobo Aura */
>  #define NTXEC_VERSION_TOLINO_SHINE2 0xf110 /* found in Tolino Shine 2 HD */
>  
> +/*
> + * found in Tolino Vision, contains RTC, ADC, PWM, home pad
> + */

Could you please use the same formatting as the others.

> +#define NTXEC_VERSION_TOLINO_VISION 0xe135
>  #endif
> -- 
> 2.30.2
> 

-- 
Lee Jones [李琼斯]