linux-kernel - Re: [PATCH v2 12/14] spi: bcm63xx-hsspi: Disable spi mem dual io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ad787286-b417-83f0-0e45-b97bbe058a7f@broadcom.com>
Date:   Thu, 26 Jan 2023 18:04:27 -0800
From:   William Zhang <william.zhang@...adcom.com>
To:     Jonas Gorski <jonas.gorski@...il.com>
Cc:     Linux SPI List <linux-spi@...r.kernel.org>,
        Broadcom Kernel List <bcm-kernel-feedback-list@...adcom.com>,
        tomer.yacoby@...adcom.com, kursad.oney@...adcom.com,
        dregan@...l.com, f.fainelli@...il.com, anand.gore@...adcom.com,
        dan.beygelman@...adcom.com, joel.peshkin@...adcom.com,
        Mark Brown <broonie@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 12/14] spi: bcm63xx-hsspi: Disable spi mem dual io



On 01/26/2023 07:15 AM, Jonas Gorski wrote:
>>
>> +static bool bcm63xx_hsspi_mem_supports_op(struct spi_mem *mem,
>> +                           const struct spi_mem_op *op)
>> +{
>> +       if (!spi_mem_default_supports_op(mem, op))
>> +               return false;
>> +
>> +       /* Controller doesn't support spi mem dual/quad read cmd in prepend mode */
>> +       if ((op->cmd.opcode == 0xbb) || (op->cmd.opcode == 0xeb))
> 
> There are defines in linux/mtd/spi-nor.h you can use:
> 
> if ((op->cmd.opcode == SPINOR_OP_READ_1_2_2) || (op->cmd.opcode ==
> SPINOR_OP_READ_1_4_4))
> 
> Though SPINOR_OP_READ_1_4_4 seems to be redundant, since the
> controller does not support quad mode, and does not advertise it, so
> it should never even be an option.
> 
> Looking at that file, instead what is missing is
> SPINOR_OP_READ_1_2_2_4B (0xbc) which shouldn't be usable either.
> 

You are right.  I was only looking at the spi nand header which does not 
have this clear definition.  Will use them and drop the quad IO opcode 
for the reason you mentioned.


Download attachment "smime.p7s" of type "application/pkcs7-signature" (4212 bytes)