[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fd8f34fa-77d1-98c4-64f3-cc5ffeb7bd0e@quicinc.com>
Date: Fri, 27 Jan 2023 21:15:02 +0530
From: Devi Priya <quic_devipriy@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...aro.org>, <agross@...nel.org>,
<andersson@...nel.org>, <robh+dt@...nel.org>,
<krzysztof.kozlowski+dt@...aro.org>, <mturquette@...libre.com>,
<sboyd@...nel.org>, <jassisinghbrar@...il.com>,
<catalin.marinas@....com>, <will@...nel.org>,
<shawnguo@...nel.org>, <arnd@...db.de>,
<marcel.ziswiler@...adex.com>, <dmitry.baryshkov@...aro.org>,
<nfraprado@...labora.com>, <broonie@...nel.org>,
<linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>
CC: <quic_srichara@...cinc.com>, <quic_gokulsri@...cinc.com>,
<quic_sjaganat@...cinc.com>, <quic_kathirav@...cinc.com>,
<quic_arajkuma@...cinc.com>, <quic_anusha@...cinc.com>,
<quic_poovendh@...cinc.com>
Subject: Re: [PATCH 5/6] dt-bindings: mailbox: Add compatible for IPQ9574
On 1/13/2023 8:43 PM, Konrad Dybcio wrote:
>
>
> On 13.01.2023 15:36, devi priya wrote:
>> Add the mailbox compatible string for IPQ9574 SoC
>>
>> Co-developed-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> Signed-off-by: Praveenkumar I <quic_ipkumar@...cinc.com>
>> Signed-off-by: devi priya <quic_devipriy@...cinc.com>
>> ---
> Binding changes should come before driver changes, so that
> you're not introducing an "illegal" compatible and only
> "legalize" it later - please reorder the patch.
>
> Konrad
Understood, will reorder the patches in V2
>> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> index 943f9472ae10..9e076758a58a 100644
>> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> - qcom,msm8976-apcs-kpss-global
>> - qcom,msm8996-apcs-hmss-global
>> - qcom,msm8998-apcs-hmss-global
>> @@ -113,6 +114,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> clocks:
>> @@ -129,6 +131,7 @@ allOf:
>> enum:
>> - qcom,ipq6018-apcs-apps-global
>> - qcom,ipq8074-apcs-apps-global
>> + - qcom,ipq9574-apcs-apps-global
>> then:
>> properties:
>> '#clock-cells':
Best Regards,
Devi Priya
Powered by blists - more mailing lists