linux-kernel - Re: [PATCH v3 2/4] KVM: arm64: Add helper vgic_write_guest

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4b3ee35-a0d7-80f6-c64f-f9056c5b6110@linux.dev>
Date:   Fri, 27 Jan 2023 23:57:40 +0800
From:   Zenghui Yu <zenghui.yu@...ux.dev>
To:     Gavin Shan <gshan@...hat.com>, kvmarm@...ts.linux.dev
Cc:     kvmarm@...ts.cs.columbia.edu, kvm@...r.kernel.org,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, pbonzini@...hat.com,
        corbet@....net, maz@...nel.org, james.morse@....com,
        suzuki.poulose@....com, oliver.upton@...ux.dev,
        yuzenghui@...wei.com, catalin.marinas@....com, will@...nel.org,
        yuzhe@...china.com, isaku.yamahata@...el.com, seanjc@...gle.com,
        ricarkol@...gle.com, eric.auger@...hat.com, renzhengeek@...il.com,
        reijiw@...gle.com, shan.gavin@...il.com
Subject: Re: [PATCH v3 2/4] KVM: arm64: Add helper vgic_write_guest_lock()

[ just coming back from holiday, sorry for the late reply ]

On 2023/1/27 07:54, Gavin Shan wrote:
> Currently, the unknown no-running-vcpu sites are reported when a
> dirty page is tracked by mark_page_dirty_in_slot(). Until now, the
> only known no-running-vcpu site is saving vgic/its tables through
> KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_SAVE_TABLES} command on KVM device
> "kvm-arm-vgic-its". Unfortunately, there are more unknown sites to
> be handled and no-running-vcpu context will be allowed in these
> sites: (1) KVM_DEV_ARM_{VGIC_GRP_CTRL, ITS_RESTORE_TABLES} command
> on KVM device "kvm-arm-vgic-its" to restore vgic/its tables. The
> vgic3 LPI pending status could be restored. (2) Save vgic3 pending

We typically write it as "VGICv3".

> table through KVM_DEV_ARM_{VGIC_GRP_CTRL, VGIC_SAVE_PENDING_TABLES}
> command on KVM device "kvm-arm-vgic-v3".
> 
> In order to handle those unknown cases, we need a unified helper
> vgic_write_guest_lock(). struct vgic_dist::save_its_tables_in_progress
> is also renamed to struct vgic_dist::save_tables_in_progress.

How about renaming it to 'write_tables_in_progress' which would look a
bit more generic? The rest looks good to me.

Thanks,
Zenghui