linux-kernel - RE: [PATCH 2/6] ASoC: amd: yc: Add a module parameter to influence pdm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MN0PR12MB61014C004C798F7DE8682AAFE2CC9@MN0PR12MB6101.namprd12.prod.outlook.com>
Date:   Fri, 27 Jan 2023 16:25:45 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Jaroslav Kysela <perex@...ex.cz>,
        "Mukunda, Vijendar" <Vijendar.Mukunda@....com>,
        "Saba Kareem, Syed" <Syed.SabaKareem@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     "Pananchikkal, Renjith" <Renjith.Pananchikkal@....com>,
        Mark Pearson <mpearson@...ovo.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
Subject: RE: [PATCH 2/6] ASoC: amd: yc: Add a module parameter to influence
 pdm_gain

[AMD Official Use Only - General]



> -----Original Message-----
> From: Jaroslav Kysela <perex@...ex.cz>
> Sent: Friday, January 27, 2023 10:23
> To: Limonciello, Mario <Mario.Limonciello@....com>; Mukunda, Vijendar
> <Vijendar.Mukunda@....com>; Saba Kareem, Syed
> <Syed.SabaKareem@....com>; linux-kernel@...r.kernel.org
> Cc: Pananchikkal, Renjith <Renjith.Pananchikkal@....com>; Mark Pearson
> <mpearson@...ovo.com>; Liam Girdwood <lgirdwood@...il.com>; Mark
> Brown <broonie@...nel.org>; Takashi Iwai <tiwai@...e.com>; alsa-
> devel@...a-project.org
> Subject: Re: [PATCH 2/6] ASoC: amd: yc: Add a module parameter to
> influence pdm_gain
> 
> On 27. 01. 23 17:01, Mario Limonciello wrote:
> > In case of regressions for any users that the new pdm_gain value is
> > too high and for additional debugging, introduce a module parameter
> > that would let them configure it.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> > ---
> >   sound/soc/amd/yc/acp6x-pdm-dma.c | 7 ++++++-
> >   sound/soc/amd/yc/acp6x.h         | 2 +-
> >   2 files changed, 7 insertions(+), 2 deletions(-)
> 
> ...
> 
> >   	pdm_ctrl = acp6x_readl(acp_base + ACP_WOV_MISC_CTRL);
> > -	pdm_ctrl |= ACP_WOV_MISC_CTRL_MASK;
> > +	pdm_ctrl |= FIELD_PREP(ACP_WOV_GAIN_CONTROL, pdm_gain);
> 
> The bits should be zeroed (AND - &) before OR to make sure that the correct
> value is written to the register. More related patches are affected.

I had consider this, but the hardware default at reset is 0x0.  Do you think it's
still necessary for posterity?