linux-kernel - [tip: x86/core] x86: Suppress KMSAN reports in arch_within_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <167484094672.4906.1078127795504041641.tip-bot2@tip-bot2>
Date:   Fri, 27 Jan 2023 17:35:46 -0000
From:   "tip-bot2 for Alexander Potapenko" <tip-bot2@...utronix.de>
To:     linux-tip-commits@...r.kernel.org
Cc:     Alexander Potapenko <glider@...gle.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Eric Biggers <ebiggers@...gle.com>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: [tip: x86/core] x86: Suppress KMSAN reports in arch_within_stack_frames()

The following commit has been merged into the x86/core branch of tip:

Commit-ID:     ce3ba2af9695e4bd64d797e0026321e5dca29dd3
Gitweb:        https://git.kernel.org/tip/ce3ba2af9695e4bd64d797e0026321e5dca29dd3
Author:        Alexander Potapenko <glider@...gle.com>
AuthorDate:    Fri, 18 Nov 2022 18:23:05 +01:00
Committer:     Dave Hansen <dave.hansen@...ux.intel.com>
CommitterDate: Fri, 27 Jan 2023 09:00:56 -08:00

x86: Suppress KMSAN reports in arch_within_stack_frames()

arch_within_stack_frames() performs stack walking and may confuse
KMSAN by stepping on stale shadow values. To prevent false positive
reports, disable KMSAN checks in this function.

This fixes KMSAN's interoperability with CONFIG_HARDENED_USERCOPY.

Signed-off-by: Alexander Potapenko <glider@...gle.com>
Signed-off-by: Dave Hansen <dave.hansen@...ux.intel.com>
Tested-by: Eric Biggers <ebiggers@...gle.com>
Link: https://github.com/google/kmsan/issues/89
Link: https://lore.kernel.org/lkml/Y3b9AAEKp2Vr3e6O@sol.localdomain/
Link: https://lore.kernel.org/all/20221118172305.3321253-1-glider%40google.com
---
 arch/x86/include/asm/thread_info.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/x86/include/asm/thread_info.h b/arch/x86/include/asm/thread_info.h
index f0cb881..f1cccba 100644
--- a/arch/x86/include/asm/thread_info.h
+++ b/arch/x86/include/asm/thread_info.h
@@ -163,7 +163,12 @@ struct thread_info {
  *	GOOD_FRAME	if within a frame
  *	BAD_STACK	if placed across a frame boundary (or outside stack)
  *	NOT_STACK	unable to determine (no frame pointers, etc)
+ *
+ * This function reads pointers from the stack and dereferences them. The
+ * pointers may not have their KMSAN shadow set up properly, which may result
+ * in false positive reports. Disable instrumentation to avoid those.
  */
+__no_kmsan_checks
 static inline int arch_within_stack_frames(const void * const stack,
 					   const void * const stackend,
 					   const void *obj, unsigned long len)