linux-kernel - Re: [PATCH v4 02/24] powerpc/pseries: Fix alignment of PLPKS structures and buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2de207dadb936f25db123ae2d02aea91a9841656.camel@linux.ibm.com>
Date:   Fri, 27 Jan 2023 14:20:37 +1100
From:   Andrew Donnellan <ajd@...ux.ibm.com>
To:     David Laight <David.Laight@...LAB.COM>,
        "'Segher Boessenkool'" <segher@...nel.crashing.org>,
        Michael Ellerman <mpe@...erman.id.au>
Cc:     "gjoyce@...ux.ibm.com" <gjoyce@...ux.ibm.com>,
        "erichte@...ux.ibm.com" <erichte@...ux.ibm.com>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "nayna@...ux.ibm.com" <nayna@...ux.ibm.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "zohar@...ux.ibm.com" <zohar@...ux.ibm.com>,
        "sudhakar@...ux.ibm.com" <sudhakar@...ux.ibm.com>,
        "ruscur@...sell.cc" <ruscur@...sell.cc>,
        "joel@....id.au" <joel@....id.au>,
        "bgray@...ux.ibm.com" <bgray@...ux.ibm.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "gcwilson@...ux.ibm.com" <gcwilson@...ux.ibm.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [PATCH v4 02/24] powerpc/pseries: Fix alignment of PLPKS
 structures and buffers

On Thu, 2023-01-26 at 17:31 +0000, David Laight wrote:
> Changing the size to kzalloc() doesn't help.
> The alignment depends on the allocator and is only required to have
> a relatively small alignment (ARCH_MINALIGN?) regardless of the size.
> 
> IIRC one of the allocators adds a small header to every item.
> It won't return 16 byte aligned items at all.

I'm relying on the behaviour described in Documentation/core-
api/memory-allocation.rst:

    The address of a chunk allocated with kmalloc is aligned to at
    least ARCH_KMALLOC_MINALIGN bytes. For sizes which are a power of
    two, the alignment is also guaranteed to be at least the respective
    size.

Is this wrong?


Andrew

-- 
Andrew Donnellan    OzLabs, ADL Canberra
ajd@...ux.ibm.com   IBM Australia Limited