linux-kernel - Re: [PATCH v1 1/1] lib/string: Use strchr() in strpbrk()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <167484572215.2632904.14390662378665291104.b4-ty@chromium.org>
Date:   Fri, 27 Jan 2023 10:55:25 -0800
From:   Kees Cook <keescook@...omium.org>
To:     andriy.shevchenko@...ux.intel.com, linux-kernel@...r.kernel.org
Cc:     Kees Cook <keescook@...omium.org>, andy@...nel.org,
        linux@...musvillemoes.dk, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH v1 1/1] lib/string: Use strchr() in strpbrk()

On Fri, 27 Jan 2023 17:51:35 +0200, Andy Shevchenko wrote:
> Use strchr() instead of open coding it as it's done elsewhere in
> the same file. Either we will have similar to what it was or possibly
> better performance in case architecture implements its own strchr().
> 
> Memory wise on x86_64 bloat-o-meter shows the following
> 
>   Function           old     new   delta
>   strsep             111     102      -9
>   Total: Before=2763, After=2754, chg -0.33%
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] lib/string: Use strchr() in strpbrk()
      https://git.kernel.org/kees/c/a5f5ee7c49da

-- 
Kees Cook