linux-kernel - Re: [PATCH] USB: MAX3421: Handle USB NAK correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2023 07:22:52 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: MAX3421: Handle USB NAK correctly

On Fri, Jan 27, 2023 at 03:47:34PM +1300, Mark Tomlinson wrote:
> A USB peripheral can respond with a NAK if it is not yet ready to
> send/receive data. In this case, the transaction should be retried. The
> MAX3421 driver did do this, and switched to a different type of retry
> after a number of 'fast' retries. On at least some USB flash devices,
> this second type of retry never succeeds. This patch changes the
> behaviour so that 'fast' retries continue.
> 
> Signed-off-by: Mark Tomlinson <mark.tomlinson@...iedtelesis.co.nz>
> ---
>  drivers/usb/host/max3421-hcd.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)

What commit id does this fix?  And should it be backported to older
kernel trees?

thanks,

greg k-h