linux-kernel - Re: [PATCH 5.10 1/1] xhci: Set HCD flag to defer primary roothub registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2023 08:25:16 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Adrian Zaharia <adrian.zaharia@...driver.com>
Cc:     stable@...r.kernel.org, mathias.nyman@...el.com,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5.10 1/1] xhci: Set HCD flag to defer primary roothub
 registration

On Wed, Jan 25, 2023 at 03:33:59PM +0200, Adrian Zaharia wrote:
> From: Kishon Vijay Abraham I <kishon@...com>
> 
> [ Upstream commit b7a4f9b5d0e4b6dd937678c546c0b322dd1a4054 ]
> 
> Set "HCD_FLAG_DEFER_RH_REGISTER" to hcd->flags in xhci_run() to defer
> registering primary roothub in usb_add_hcd() if xhci has two roothubs.
> This will make sure both primary roothub and secondary roothub will be
> registered along with the second HCD.
> This is required for cold plugged USB devices to be detected in certain
> PCIe USB cards (like Inateck USB card connected to AM64 EVM or J7200 EVM).
> 
> This patch has been added and reverted earier as it triggered a race
> in usb device enumeration.
> That race is now fixed in 5.16-rc3, and in stable back to 5.4
> commit 6cca13de26ee ("usb: hub: Fix locking issues with address0_mutex")
> commit 6ae6dc22d2d1 ("usb: hub: Fix usb enumeration issue due to address0
> race")
> 
> [minor rebase change, and commit message update -Mathias]
> 
> CC: stable@...r.kernel.org # 5.4+
> Suggested-by: Mathias Nyman <mathias.nyman@...ux.intel.com>
> Tested-by: Chris Chiu <chris.chiu@...onical.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> Link: https://lore.kernel.org/r/20220510091630.16564-3-kishon@ti.com
> Signed-off-by: Adrian Zaharia <Adrian.Zaharia@...driver.com>
> ---
>  drivers/usb/host/xhci.c | 2 ++
>  1 file changed, 2 insertions(+)

You dropped my original signed-off-by?  Odd...

Anyway, now queued up.

greg k-h