linux-kernel - Re: [PATCH v3] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9OLtbN5uhyPYxyj@ninjato>
Date:   Fri, 27 Jan 2023 09:30:45 +0100
From:   Wolfram Sang <wsa+renesas@...g-engineering.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-renesas-soc@...r.kernel.org,
        Prabhakar <prabhakar.csengg@...il.com>,
        Cong Dang <cong.dang.xn@...esas.com>,
        Hai Pham <hai.pham.ud@...esas.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] memory: renesas-rpc-if: Fix PHYCNT.STRTIM setting


> > -       rpc->type = (uintptr_t)of_device_get_match_data(dev);
> > +       rpc->size = resource_size(res);
> 
> Nit: No need to move the initialization of rpc->size.

True. It is more cosmetic to have all rpc->* inits in one block. But I
think it is worth it.

> > +       regmap_update_bits(rpc->regmap, RPCIF_PHYCNT,
> > +                          /* create mask with all affected bits set */
> > +                          RPCIF_PHYCNT_STRTIM(BIT(fls(rpc->info->strtim)) - 1),
> 
> Note that this relies on the strtim value being 4 or higher.
> As this value is not user-configurable, but fixed in the driver,
> it's probably OK.

If there was a chance that newer SoCs use such a value, I'd go for the
seperate mask. But I am confident this time has passed and the next
value is likely >15.


> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)