linux-kernel - Re: [PATCH -next] media: v4l2-ctrls: clean up some inconsistent indentings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a66fec48-ae2e-034f-ecb2-4b0c3196d59c@xs4all.nl>
Date:   Fri, 27 Jan 2023 09:36:40 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Yang Li <yang.lee@...ux.alibaba.com>, mchehab@...nel.org
Cc:     linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH -next] media: v4l2-ctrls: clean up some inconsistent
 indentings

On 16/12/2022 08:42, Yang Li wrote:
> clean up some inconsistent indentings to improve the readability of the
> code.
> 
> drivers/media/v4l2-core/v4l2-ctrls-api.c:154 user_to_new() warn: inconsistent indenting

Thank you for the patch, but the actual fix is already on its way
to mainline:

https://patchwork.linuxtv.org/project/linux-media/patch/69624c54-7cbd-7362-c468-f8ffea9614be@xs4all.nl/

Rejecting this in patchwork.

Regards,

	Hans

> 
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3503
> Fixes: 73278d483378 ("media: v4l2-ctrls-api.c: add back dropped ctrl->is_new = 1")
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@...ux.alibaba.com>
> ---
>  drivers/media/v4l2-core/v4l2-ctrls-api.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-ctrls-api.c b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> index 3d3b6dc24ca6..3bee4ad5be7c 100644
> --- a/drivers/media/v4l2-core/v4l2-ctrls-api.c
> +++ b/drivers/media/v4l2-core/v4l2-ctrls-api.c
> @@ -150,8 +150,8 @@ static int user_to_new(struct v4l2_ext_control *c, struct v4l2_ctrl *ctrl)
>  			 * then return an error.
>  			 */
>  			if (strlen(ctrl->p_new.p_char) == ctrl->maximum && last)
> -			ctrl->is_new = 1;
> -				return -ERANGE;
> +				ctrl->is_new = 1;
> +			return -ERANGE;
>  		}
>  		return ret;
>  	default: