[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <06bbd154-0777-11d5-f9db-65f6f701628d@redhat.com>
Date: Fri, 27 Jan 2023 10:47:25 +0100
From: Hans de Goede <hdegoede@...hat.com>
To: Arnd Bergmann <arnd@...nel.org>, Mark Gross <markgross@...nel.org>,
Mario Limonciello <mario.limonciello@....com>
Cc: Arnd Bergmann <arnd@...db.de>,
Shyam Sundar S K <Shyam-sundar.S-k@....com>,
Naveen Krishna Chatradhi <NaveenKrishna.Chatradhi@....com>,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86/amd: pmc: add CONFIG_SERIO dependency
Hi,
On 1/27/23 10:39, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> Using the serio subsystem now requires the code to be reachable:
>
> x86_64-linux-ld: drivers/platform/x86/amd/pmc.o: in function `amd_pmc_suspend_handler':
> pmc.c:(.text+0x86c): undefined reference to `serio_bus'
>
> Add the usual dependency: as other users of serio use 'select'
> rather than 'depends on', use the same here.
>
> Fixes: 8e60615e8932 ("platform/x86/amd: pmc: Disable IRQ1 wakeup for RN/CZN")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
Thanks Arnd, I'll include this in my next fixes pull-req to Linus.
Regards,
Hans
> ---
> drivers/platform/x86/amd/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/amd/Kconfig b/drivers/platform/x86/amd/Kconfig
> index a825af8126c8..2ce8cb2170df 100644
> --- a/drivers/platform/x86/amd/Kconfig
> +++ b/drivers/platform/x86/amd/Kconfig
> @@ -8,6 +8,7 @@ source "drivers/platform/x86/amd/pmf/Kconfig"
> config AMD_PMC
> tristate "AMD SoC PMC driver"
> depends on ACPI && PCI && RTC_CLASS
> + select SERIO
> help
> The driver provides support for AMD Power Management Controller
> primarily responsible for S2Idle transactions that are driven from
Powered by blists - more mailing lists