linux-kernel - [PATCH] regulator: max20411: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Jan 2023 11:17:26 +0100
From:   Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
To:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: [PATCH] regulator: max20411: Convert to i2c's .probe_new()

The probe function doesn't make use of the i2c_device_id * parameter so
it can be trivially converted.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
---
There is an ongoing effort to convert all drivers to .probe_new to
eventually drop .probe with the i2c_device_id parameter. This driver
currently sits in next so wasn't on my radar before.

My plan is to tackle that after the next merge window. So I ask you to
either apply this patch during the next merge window or accept that it
will go in via the i2c tree together with the patch that drops .probe().
---
 drivers/regulator/max20411-regulator.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/max20411-regulator.c b/drivers/regulator/max20411-regulator.c
index b4faad54c458..e75d16048e2f 100644
--- a/drivers/regulator/max20411-regulator.c
+++ b/drivers/regulator/max20411-regulator.c
@@ -96,8 +96,7 @@ static const struct regulator_desc max20411_desc = {
 	.n_ramp_values = ARRAY_SIZE(max20411_slew_rates),
 };
 
-static int max20411_probe(struct i2c_client *client,
-			  const struct i2c_device_id *id)
+static int max20411_probe(struct i2c_client *client)
 {
 	struct regulator_init_data *init_data;
 	struct device *dev = &client->dev;
@@ -156,7 +155,7 @@ static struct i2c_driver max20411_i2c_driver = {
 		.name = "max20411",
 		.of_match_table	= of_max20411_match_tbl,
 	},
-	.probe = max20411_probe,
+	.probe_new = max20411_probe,
 	.id_table = max20411_id,
 };
 module_i2c_driver(max20411_i2c_driver);
-- 
2.39.0