linux-kernel - Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230127103204.t3k53rqaygxdlvyl@pengutronix.de>
Date:   Fri, 27 Jan 2023 11:32:04 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Guenter Roeck <linux@...ck-us.net>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>
Cc:     Uwe Kleine-König <uwe@...ine-koenig.org>,
        linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wolfram Sang <wsa@...nel.org>,
        Angel Iglesias <ang.iglesiasg@...il.com>,
        linux-i2c@...r.kernel.org, kernel@...gutronix.de,
        Grant Likely <grant.likely@...aro.org>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 596/606] watchdog: ziirave_wdt: Convert to i2c's
 .probe_new()

Hello,

On Fri, Nov 18, 2022 at 02:57:47PM -0800, Guenter Roeck wrote:
> On Fri, Nov 18, 2022 at 11:45:30PM +0100, Uwe Kleine-König wrote:
> > From: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > 
> > The probe function doesn't make use of the i2c_device_id * parameter so it
> > can be trivially converted.
> > 
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

This patch hasn't made it into next yet. Is it still on your radar?

My plans for this series is to complete the conversion after the next
merge window which should include most patches from this series.

So I ask you to either take this patch during the next merge window or
accept that it will be applied together with the i2c core conversion
that drops .probe() with the i2c_device_id parameter.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)