linux-kernel - Re: [PATCH] fsi: Add aliased device numbering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8fa108c9dedf884eab6dacaf3e9680b7c66c4202.camel@ozlabs.org>
Date:   Fri, 27 Jan 2023 09:03:23 +0800
From:   Jeremy Kerr <jk@...abs.org>
To:     Eddie James <eajames@...ux.ibm.com>, linux-fsi@...ts.ozlabs.org
Cc:     linux-kernel@...r.kernel.org, alistair@...ple.id.au, joel@....id.au
Subject: Re: [PATCH] fsi: Add aliased device numbering

Hi Eddie,

> The I2C and SPI subsystems can use an aliased name to number the
> device. Add similar support to the FSI subsystem for any device type.

Sounds good!

However, the majority of this patch seems to be the change to a (const)
enum value, which you then convert to a string to generate the
non-number component of the device name.

Does:

       dev_set_name(&scom->dev, "%s%d", fsi_get_dev_type_name(fsi_dev_scom), didx);

have much of a benefit over:

       dev_set_name(&scom->dev, "scom%d", didx);

?

Cheers,


Jeremy