[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9d0a15ee-c5d0-7d3c-7aa8-58383211f637@amd.com>
Date: Fri, 27 Jan 2023 16:47:45 +0530
From: Nipun Gupta <nipun.gupta@....com>
To: Randy Dunlap <rdunlap@...radead.org>, robh+dt@...nel.org,
krzysztof.kozlowski+dt@...aro.org, gregkh@...uxfoundation.org,
rafael@...nel.org, eric.auger@...hat.com,
alex.williamson@...hat.com, cohuck@...hat.com,
song.bao.hua@...ilicon.com, mchehab+huawei@...nel.org,
maz@...nel.org, f.fainelli@...il.com, jeffrey.l.hugo@...il.com,
saravanak@...gle.com, Michael.Srba@...nam.cz, mani@...nel.org,
yishaih@...dia.com, jgg@...pe.ca, jgg@...dia.com,
robin.murphy@....com, will@...nel.org, joro@...tes.org,
masahiroy@...nel.org, ndesaulniers@...gle.com,
linux-arm-kernel@...ts.infradead.org, linux-kbuild@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Cc: okaya@...nel.org, harpreet.anand@....com, nikhil.agarwal@....com,
michal.simek@....com, git@....com
Subject: Re: [PATCH v6 7/7] cdx: add device attributes
On 1/26/2023 10:25 PM, Randy Dunlap wrote:
> Hi--
>
> On 1/26/23 02:46, Nipun Gupta wrote:
>> diff --git a/Documentation/ABI/testing/sysfs-bus-cdx b/Documentation/ABI/testing/sysfs-bus-cdx
>> index 8c2425fdb6d9..69bdbc891743 100644
>> --- a/Documentation/ABI/testing/sysfs-bus-cdx
>> +++ b/Documentation/ABI/testing/sysfs-bus-cdx
>> @@ -10,3 +10,47 @@ Description:
>> For example::
>>
>> # echo 1 > /sys/bus/cdx/rescan
>> +
>> +What: /sys/bus/cdx/devices/.../vendor
>> +Date: January 2023
>> +Contact: nipun.gupta@....com
>> +Description:
>> + Vendor ID for this CDX device. Vendor ID is 16 bit
>> + identifier which is specific to the device manufacturer.
>> + Combination of Vendor ID and Device ID identifies a device.
>> +
>> +What: /sys/bus/cdx/devices/.../device
>> +Date: January 2023
>> +Contact: nipun.gupta@....com
>> +Description:
>> + Device ID for this CDX device. Device ID is a 16 bit
>> + identifier to identify a device type within the range
>> + of a device manufacturer.
>> + Combination of Vendor ID and Device ID identifies a device.
>> +
>> +What: /sys/bus/cdx/devices/.../reset
>> +Date: January 2023
>> +Contact: nipun.gupta@....com
>> +Description:
>
> Reads better without "would":
>
>> + Writing a non-zero value to this file would reset the CDX> + device. On resetting the device, the corresponding driver
>> + would be notified twice, once before the device is being
>> + reset, and again after the reset has been complete.
>
>
> Writing a non-zero value to this file resets the CDX
> device. On resetting the device, the corresponding driver
> is notified twice, once before the device is being
> reset, and again after the reset has been complete.
>
>> +
>> + For example::
>> +
>> + # echo 1 > /sys/bus/cdx/.../reset
>> +
>> +What: /sys/bus/cdx/devices/.../remove
>> +Date: January 2023
>> +Contact: tarak.reddy@....com
>> +Description:
>> + Writing a non-zero value to this file would remove the
>> + corrosponding device from the CDX bus. If the device is
>> + to be reconfigured in the Hardware, the device can be
>> + removed, so that the device driver does not access the
>> + device while it is being reconfigured.
>
> and: (also fix typo of corresponding)
Thanks for the review. Will fix and update these.
Regards
Nipun
>
> Writing a non-zero value to this file removes the
> corresponding device from the CDX bus. If the device is
> to be reconfigured in the Hardware, the device can be
> removed, so that the device driver does not access the
> device while it is being reconfigured.
>
>> +
>> + For example::
>> +
>> + # echo 1 > /sys/bus/cdx/devices/.../remove
>
> --
> ~Randy
Powered by blists - more mailing lists