| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230127114108.10025-15-joey.gouly@arm.com>
Date: Fri, 27 Jan 2023 11:40:55 +0000
From: Joey Gouly <joey.gouly@....com>
To: Andrew Jones <andrew.jones@...ux.dev>, <kvmarm@...ts.linux.dev>,
<kvm@...r.kernel.org>
CC: <joey.gouly@....com>, Alexandru Elisei <alexandru.elisei@....com>,
Christoffer Dall <christoffer.dall@....com>,
Fuad Tabba <tabba@...gle.com>,
Jean-Philippe Brucker <jean-philippe@...aro.org>,
Joey Gouly <Joey.Gouly@....com>, Marc Zyngier <maz@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Oliver Upton <oliver.upton@...ux.dev>,
Paolo Bonzini <pbonzini@...hat.com>,
Quentin Perret <qperret@...gle.com>,
Steven Price <steven.price@....com>,
Suzuki K Poulose <suzuki.poulose@....com>,
"Thomas Huth" <thuth@...hat.com>, Will Deacon <will@...nel.org>,
Zenghui Yu <yuzenghui@...wei.com>,
<linux-coco@...ts.linux.dev>, <kvmarm@...ts.cs.columbia.edu>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>,
Gareth Stockwell <gareth.stockwell@....com>
Subject: [RFC kvm-unit-tests 14/27] arm: realm: add hvc and RSI_HOST_CALL tests
From: Gareth Stockwell <gareth.stockwell@....com>
Test that a HVC instruction in a Realm is turned into an undefined exception.
Test that RSI_HOST_CALL passes through to the Hypervisor.
Signed-off-by: Gareth Stockwell <gareth.stockwell@....com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@....com>
Signed-off-by: Joey Gouly <joey.gouly@....com>
---
arm/realm-rsi.c | 110 +++++++++++++++++++++++++++++++++++++++++++++-
arm/unittests.cfg | 15 +++++++
2 files changed, 124 insertions(+), 1 deletion(-)
diff --git a/arm/realm-rsi.c b/arm/realm-rsi.c
index d793f305..8a7e9622 100644
--- a/arm/realm-rsi.c
+++ b/arm/realm-rsi.c
@@ -14,6 +14,96 @@
#include <asm/pgtable.h>
#include <asm/processor.h>
+#define FID_SMCCC_VERSION 0x80000000
+#define FID_INVALID 0xc5000041
+
+#define SMCCC_VERSION_1_1 0x10001
+#define SMCCC_SUCCESS 0
+#define SMCCC_NOT_SUPPORTED -1
+
+static bool unknown_taken;
+
+static void unknown_handler(struct pt_regs *regs, unsigned int esr)
+{
+ report_info("unknown_handler: esr=0x%x", esr);
+ unknown_taken = true;
+}
+
+static void hvc_call(unsigned int fid)
+{
+ struct smccc_result res;
+
+ unknown_taken = false;
+ arm_smccc_hvc(fid, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, &res);
+
+ if (unknown_taken) {
+ report(true, "FID=0x%x caused Unknown exception", fid);
+ } else {
+ report(false, "FID=0x%x did not cause Unknown exception", fid);
+ report_info("x0: 0x%lx", res.r0);
+ report_info("x1: 0x%lx", res.r1);
+ report_info("x2: 0x%lx", res.r2);
+ report_info("x3: 0x%lx", res.r3);
+ report_info("x4: 0x%lx", res.r4);
+ report_info("x5: 0x%lx", res.r5);
+ report_info("x6: 0x%lx", res.r6);
+ report_info("x7: 0x%lx", res.r7);
+ }
+}
+
+static void rsi_test_hvc(void)
+{
+ report_prefix_push("hvc");
+
+ /* Test that HVC causes Undefined exception, regardless of FID */
+ install_exception_handler(EL1H_SYNC, ESR_EL1_EC_UNKNOWN, unknown_handler);
+ hvc_call(FID_SMCCC_VERSION);
+ hvc_call(FID_INVALID);
+ install_exception_handler(EL1H_SYNC, ESR_EL1_EC_UNKNOWN, NULL);
+
+ report_prefix_pop();
+}
+
+static void host_call(unsigned int fid, unsigned long expected_x0)
+{
+ struct smccc_result res;
+ struct rsi_host_call __attribute__((aligned(256))) host_call_data = { 0 };
+
+ host_call_data.gprs[0] = fid;
+
+ arm_smccc_smc(SMC_RSI_HOST_CALL, virt_to_phys(&host_call_data),
+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, &res);
+
+ if (res.r0) {
+ report(false, "RSI_HOST_CALL returned 0x%lx", res.r0);
+ } else {
+ if (host_call_data.gprs[0] == expected_x0) {
+ report(true, "FID=0x%x x0=0x%lx",
+ fid, host_call_data.gprs[0]);
+ } else {
+ report(false, "FID=0x%x x0=0x%lx expected=0x%lx",
+ fid, host_call_data.gprs[0], expected_x0);
+ report_info("x1: 0x%lx", host_call_data.gprs[1]);
+ report_info("x2: 0x%lx", host_call_data.gprs[2]);
+ report_info("x3: 0x%lx", host_call_data.gprs[3]);
+ report_info("x4: 0x%lx", host_call_data.gprs[4]);
+ report_info("x5: 0x%lx", host_call_data.gprs[5]);
+ report_info("x6: 0x%lx", host_call_data.gprs[6]);
+ }
+ }
+}
+
+static void rsi_test_host_call(void)
+{
+ report_prefix_push("host_call");
+
+ /* Test that host calls return expected values */
+ host_call(FID_SMCCC_VERSION, SMCCC_VERSION_1_1);
+ host_call(FID_INVALID, SMCCC_NOT_SUPPORTED);
+
+ report_prefix_pop();
+}
+
static void rsi_test_version(void)
{
int version;
@@ -36,6 +126,8 @@ static void rsi_test_version(void)
int main(int argc, char **argv)
{
+ int i;
+
report_prefix_push("rsi");
if (!is_realm()) {
@@ -43,7 +135,23 @@ int main(int argc, char **argv)
goto exit;
}
- rsi_test_version();
+ if (argc < 2) {
+ rsi_test_version();
+ rsi_test_host_call();
+ rsi_test_hvc();
+ } else {
+ for (i = 1; i < argc; i++) {
+ if (strcmp(argv[i], "version") == 0) {
+ rsi_test_version();
+ } else if (strcmp(argv[i], "hvc") == 0) {
+ rsi_test_hvc();
+ } else if (strcmp(argv[i], "host_call") == 0) {
+ rsi_test_host_call();
+ } else {
+ report_abort("Unknown subtest '%s'", argv[1]);
+ }
+ }
+ }
exit:
return report_summary();
}
diff --git a/arm/unittests.cfg b/arm/unittests.cfg
index ce1b5ad9..3cdb1a98 100644
--- a/arm/unittests.cfg
+++ b/arm/unittests.cfg
@@ -280,5 +280,20 @@ groups = debug migration
[realm-rsi]
file = realm-rsi.flat
groups = nodefault realms
+extra_params = -append 'version'
+accel = kvm
+arch = arm64
+
+[realm-host-call]
+file = realm-rsi.flat
+groups = nodefault realms
+extra_params = -append 'host_call'
+accel = kvm
+arch = arm64
+
+[realm-hvc]
+file = realm-rsi.flat
+groups = nodefault realms
+extra_params = -append 'hvc'
accel = kvm
arch = arm64
--
2.17.1
Powered by blists - more mailing lists