linux-kernel - [PATCH] replace BUG_ON to WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230127115844.GA1124261@min-iamroot>
Date:   Fri, 27 Jan 2023 20:58:44 +0900
From:   Hyunmin Lee <hn.min.lee@...il.com>
To:     Andrew Morton <akpm@...ux-foundation.org>,
        Uladzislau Rezki <urezki@...il.com>,
        Christoph Hellwig <hch@...radead.org>
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: [PATCH] replace BUG_ON to WARN_ON

Replace unnacessary BUG_ON to WARN_ON. These BUG_ONs verify aruguments of a function. Thus, the WARN_ONs return an EINVAL error when their condition is true.

Co-Developed-by: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
Co-Developed-by: Jeungwoo Yoo <casionwoo@...il.com>
Co-Developed-by: Sangyun Kim <sangyun.kim@....ac.kr>
Signed-off-by: Hyunmin Lee <hn.min.lee@...il.com>
Signed-off-by: Gwan-gyeong Mun <gwan-gyeong.mun@...el.com>
Signed-off-by: Jeungwoo Yoo <casionwoo@...il.com>
Signed-off-by: Sangyun Kim <sangyun.kim@....ac.kr>
Cc: Hyeonggon Yoo <42.hyeyoo@...il.com>
---
 mm/vmalloc.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 74afa2208558..9f9dba3132c5 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size,
 	int purged = 0;
 	int ret;
 
-	BUG_ON(!size);
-	BUG_ON(offset_in_page(size));
-	BUG_ON(!is_power_of_2(align));
+	if (WARN_ON(!size))
+		return ERR_PTR(-EINVAL);
+
+	if (WARN_ON(offset_in_page(size)))
+		return ERR_PTR(-EINVAL);
+
+	if (WARN_ON(!is_power_of_2(align)))
+		return ERR_PTR(-EINVAL);
 
 	if (unlikely(!vmap_initialized))
 		return ERR_PTR(-EBUSY);
-- 
2.25.1