linux-kernel - Re: [PATCH] arm64: dts: meson: radxa-zero: allow usb otg mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a4b6d79f-972c-9169-16e0-b930e2c15c51@linaro.org>
Date:   Fri, 27 Jan 2023 14:17:46 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Christian Hewitt <christianshewitt@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Kevin Hilman <khilman@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: meson: radxa-zero: allow usb otg mode

On 27/01/2023 11:39, Christian Hewitt wrote:
> Setting dr_mode to "host" prevents otg which can be useful on a board
> with limited connectivity options. So don't force host mode.
> 
> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
> ---
>   arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts b/arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts
> index e3bb6df42ff3..cf0a9be83fc4 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12a-radxa-zero.dts
> @@ -401,5 +401,4 @@ &uart_AO {
>   
>   &usb {
>   	status = "okay";
> -	dr_mode = "host";

At some point we would need to add the fusb302 node to have proper USB-C PD and mode switch handling.

Fixes: 26d1400f7457 ("arm64: dts: amlogic: add support for Radxa Zero")
Acked-by: Neil Armstrong <neil.armstrong@...aro.org