linux-kernel - Re: [PATCH] arm64: dts: microchip: use "okay" for status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13801ebac011ed24792f809643b84d7595f0d15b.camel@microchip.com>
Date:   Fri, 27 Jan 2023 14:12:12 +0100
From:   Steen Hegelund <steen.hegelund@...rochip.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Lars Povlsen <lars.povlsen@...rochip.com>,
        Daniel Machon <daniel.machon@...rochip.com>,
        <UNGLinuxDriver@...rochip.com>, <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] arm64: dts: microchip: use "okay" for status

Hi Krzysztof,

This looks "okay" to me.

BR
Steen

Reviewed-by: Steen Hegelund <Steen.Hegelund@...rochip.com>

On Fri, 2023-01-27 at 11:18 +0100, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> "okay" over "ok" is preferred for status property.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
>  arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi | 2 +-
>  arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi | 6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> index bf12be5e8d84..ed94a80bf05f 100644
> --- a/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb134_board.dtsi
> @@ -538,7 +538,7 @@ i2c_sfp20: i2c_sfp20 {
>  };
> 
>  &mdio3 {
> -       status = "ok";
> +       status = "okay";
>         phy64: ethernet-phy@64 {
>                 reg = <28>;
>         };
> diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
> b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
> index ec90bda7ed6a..0760cf2e48bc 100644
> --- a/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
> +++ b/arch/arm64/boot/dts/microchip/sparx5_pcb135_board.dtsi
> @@ -208,7 +208,7 @@ sfp_eth63: sfp-eth63 {
>  };
> 
>  &mdio0 {
> -       status = "ok";
> +       status = "okay";
>         phy0: ethernet-phy@0 {
>                 reg = <0>;
>         };
> @@ -284,7 +284,7 @@ phy23: ethernet-phy@23 {
>  };
> 
>  &mdio1 {
> -       status = "ok";
> +       status = "okay";
>         phy24: ethernet-phy@24 {
>                 reg = <0>;
>         };
> @@ -360,7 +360,7 @@ phy47: ethernet-phy@47 {
>  };
> 
>  &mdio3 {
> -       status = "ok";
> +       status = "okay";
>         phy64: ethernet-phy@64 {
>                 reg = <28>;
>         };
> --
> 2.34.1
>