lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230127150758.68eb1d29@pc-7.home>
Date:   Fri, 27 Jan 2023 15:07:58 +0100
From:   Maxime Chevallier <maxime.chevallier@...tlin.com>
To:     Vladimir Oltean <vladimir.oltean@....com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Eric Dumazet <edumazet@...gle.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        Paolo Abeni <pabeni@...hat.com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Madalin Bucur <madalin.bucur@....com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com
Subject: Re: [PATCH net-next] net: pcs: pcs-lynx: remove
 lynx_get_mdio_device() and refactor cleanup

Hi Vlad,

On Fri, 27 Jan 2023 15:43:51 +0200
Vladimir Oltean <vladimir.oltean@....com> wrote:

> On Fri, Jan 27, 2023 at 02:40:30PM +0100, Maxime Chevallier wrote:
> > One of the main difference is that the TSE pcs is memory-mapped, and
> > the merge into pcs-lynx would first require a conversion of pcs-lynx
> > to regmap.  
> 
> I suppose sooner or later you'll want to convert stuff like
> phylink_mii_c22_pcs_get_state() to regmap too?

Well that was my next part to tackle indeed...

> Can't you create an MDIO bus for the TSE PCS which translates MDIO
> reads/writes to MMIO accesses?

TBH I haven't considered that, I guess this would definitely make thing
much easier. Since the register layout of the TSE PCS is very very
similar to the C22 layout, that could be indeed justified, as it's
basically a set of standard mdio registers exposed through mmio.

Thanks for the tip.

However this current patch still makes sense though right ?

Maxime

Powered by blists - more mailing lists