linux-kernel - RE: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <001201d932ef$5e74dd70$1b5e9850$@samsung.com>
Date:   Sat, 28 Jan 2023 13:36:01 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc:     <replicant@...osl.org>, <phone-devel@...r.kernel.org>,
        <~postmarketos/upstreaming@...ts.sr.ht>,
        'Martin Jücker' <martin.juecker@...il.com>,
        "'Henrik Grimler'" <henrik@...mler.se>,
        "'Sam Protsenko'" <semen.protsenko@...aro.org>,
        "'Chanho Park'" <chanho61.park@...sung.com>,
        "'Marek Szyprowski'" <m.szyprowski@...sung.com>,
        "'Chanwoo Choi'" <cw00.choi@...sung.com>
Subject: RE: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3
 node wrapper in Exynos7



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, January 28, 2023 2:57 AM
> To: Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Alim Akhtar
> <alim.akhtar@...sung.com>; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: replicant@...osl.org; phone-devel@...r.kernel.org;
> ~postmarketos/upstreaming@...ts.sr.ht; Martin Jücker
> <martin.juecker@...il.com>; Henrik Grimler <henrik@...mler.se>; Sam
> Protsenko <semen.protsenko@...aro.org>; Chanho Park
> <chanho61.park@...sung.com>; Marek Szyprowski
> <m.szyprowski@...sung.com>; Chanwoo Choi
> <cw00.choi@...sung.com>; Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org>
> Subject: [RFT PATCH v3 4/4] arm64: dts: exynos: add unit address to DWC3
> node wrapper in Exynos7
> 
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address.  Therefore usethe address space of child
> device (actual DWC3 Controller) as the wrapper's address to
> fix:
> 
>   exynos7-espresso.dtb: soc@0: usb: {'compatible': ['samsung,exynos7-
> dwusb3'], ...
>     should not be valid under {'type': 'object'}
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

Tested on exynos7-espresso and xHCI driver still gets probed, so 

Tested-by: Alim Akhtar <alim.akhtar@...sung.com>


> 
> Changes since v1:
> 1. New patch
> ---
>  arch/arm64/boot/dts/exynos/exynos7.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> index 82fee1b7caab..b1fa68835b09 100644
> --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi
> +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi
> @@ -690,7 +690,7 @@ usbdrd_phy: phy@...00000 {
>  			#phy-cells = <1>;
>  		};
> 
> -		usbdrd: usb {
> +		usbdrd: usb@...00000 {
>  			compatible = "samsung,exynos7-dwusb3";
>  			clocks = <&clock_fsys0 ACLK_USBDRD300>,
>  			       <&clock_fsys0 SCLK_USBDRD300_SUSPENDCLK>,
> @@ -699,11 +699,11 @@ usbdrd: usb {
>  				"usbdrd30_axius_clk";
>  			#address-cells = <1>;
>  			#size-cells = <1>;
> -			ranges;
> +			ranges = <0x0 0x15400000 0x10000>;
> 
> -			usb@...00000 {
> +			usb@0 {
>  				compatible = "snps,dwc3";
> -				reg = <0x15400000 0x10000>;
> +				reg = <0x0 0x10000>;
>  				interrupts = <GIC_SPI 223
> IRQ_TYPE_LEVEL_HIGH>;
>  				phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
>  				phy-names = "usb2-phy", "usb3-phy";
> --
> 2.34.1