linux-kernel - Re: [PATCH] mips: Realtek RTL: select NO_EXCEPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46724036-fabf-7bae-41f8-1e95c5f1db5c@schinagl.nl>
Date:   Sat, 28 Jan 2023 15:39:59 +0100
From:   Olliver Schinagl <oliver@...inagl.nl>
To:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Sander Vanheule <sander@...nheule.net>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: Realtek RTL: select NO_EXCEPT_FILL

Hey Thomas,

On 27-01-2023 17:27, Thomas Bogendoerfer wrote:
> On Sun, Jan 15, 2023 at 01:19:22PM +0100, Sander Vanheule wrote:
>> Olliver has suggested to make this change, in order to reduce the delta
>> with a fully generic MIPS kernel.
>> <snip>
> applied to mips-next.
>
> Thomas.
>
Thanks Thomas, may I take this moment to poke you about a nother issue I 
don't quite understand how to resolve/figure out.


I made the realtek target work with the GENERIC_MIPS_KERNEL, but only if 
I disable SWAP_IO_SPACE[0].

While I could act all smart and ask what this is for, I better ask, why 
is this concidered 'generic'. The comment in mangle-port [1] mentions 
'sane hardware'. I don't know what is considered sane here, as the 
number of targets following generic mips seem to be around 5.

So any pointers (other then doing SWAP_IO_SPACE if !REALTEK_SOC, which I 
have now) would be appreciated


[0]: https://elixir.bootlin.com/linux/latest/source/arch/mips/Kconfig#L157

[1]: 
https://elixir.bootlin.com/linux/latest/source/arch/mips/include/asm/mach-generic/mangle-port.h#L17