linux-kernel - Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 28 Jan 2023 19:22:28 +0400
From:   Christian Hewitt <christianshewitt@...il.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        LKML <linux-kernel@...r.kernel.org>, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] media: rc: add keymap for Beelink Mini MXIII remote


> On 28 Jan 2023, at 2:11 pm, Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:
> 
> On 28/01/2023 04:41, Christian Hewitt wrote:
>> Add a keymap and bindings for the simple IR (NEC) remote used with
>> the Beelink Mini MXIII Android STB device.
>> 
>> Signed-off-by: Christian Hewitt <christianshewitt@...il.com>
>> ---
>> .../devicetree/bindings/media/rc.yaml         |  1 +
>> drivers/media/rc/keymaps/Makefile             |  1 +
>> drivers/media/rc/keymaps/rc-beelink-mxiii.c   | 54 +++++++++++++++++++
>> include/media/rc-map.h                        |  1 +
>> 4 files changed, 57 insertions(+)
>> create mode 100644 drivers/media/rc/keymaps/rc-beelink-mxiii.c
>> 
>> diff --git a/Documentation/devicetree/bindings/media/rc.yaml b/Documentation/devicetree/bindings/media/rc.yaml
>> index 266f1d5cae51..f390a5d2c82d 100644
>> --- a/Documentation/devicetree/bindings/media/rc.yaml
>> +++ b/Documentation/devicetree/bindings/media/rc.yaml
>> @@ -39,6 +39,7 @@ properties:
>>       - rc-avertv-303
>>       - rc-azurewave-ad-tu700
>>       - rc-beelink-gs1
>> +      - rc-beelink-mxiii
> 
> Bindings are separate patches. Didn't you get such feedback already?

I’ve always submitted keymaps (and only keymaps) with everything in a single patch. If
that’s not okay anymore I can resend with the bindings separated.

Christian