linux-kernel - Re: [PATCH] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory overlap with SMEM region

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAETzdaEjfCbaGj8UeBsAZGbZnvOHgMP9KTCyxsY46qL5MxUhzg@mail.gmail.com>
Date:   Sun, 29 Jan 2023 09:30:57 +1100
From:   Jamie Douglass <jamiemdouglass@...il.com>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Petr Vorel <petr.vorel@...il.com>,
        Dominik Kobinski <dominikkobinski314@...il.com>,
        Konrad Dybico <konrad.dybico@...aro.org>
Subject: Re: [PATCH] arm64: dts: qcom: msm8992-lg-bullhead: Correct memory
 overlap with SMEM region

My apologies, I completely forgot that I did that!

That change was necessary, because extending the reserved region
past 0x7000000 creates another memory overlap, this time with the
mpss_mem region:
               OF: reserved mem: OVERLAP DETECTED!
               reserved@...0000 (0x0000000006c00000--0x0000000007200000)
               overlaps with memory@...0000
               (0x0000000007000000--0x000000000ca00000)

So my original patch is correct.

Thanks,
Jamie


On Sun, 29 Jan 2023 at 01:30, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>
>
>
> On 28.01.2023 06:52, Jamie Douglass wrote:
> > A previously committed reserved memory region was overlapping with the
> > SMEM memory region, causing an error message in dmesg:
> >       OF: reserved mem: OVERLAP DETECTED!
> >       reserved@...0000 (0x0000000005000000--0x0000000007200000)
> >       overlaps with smem_region@...0000
> >       (0x0000000006a00000--0x0000000006c00000)
> > This patch splits the previous reserved memory region into two
> > reserved sections either side of the SMEM memory region.
> >
> > Signed-off-by: Jamie Douglass <jamiemdouglass@...il.com>
> > ---
> >  arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 9 +++++++--
> >  1 file changed, 7 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > index 79de9cc395c4..5e375ea73c79 100644
> > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi
> > @@ -53,8 +53,13 @@ cont_splash_mem: memory@...0000 {
> >                       no-map;
> >               };
> >
> > -             removed_region: reserved@...0000 {
> > -                     reg = <0 0x05000000 0 0x2200000>;
> > +             reserved@...0000 {
> > +                     reg = <0x0 0x05000000 0x0 0x1a00000>;
> > +                     no-map;
> > +             };
> > +
> > +             reserved@...0000 {
> > +                     reg = <0x0 0x06c00000 0x0 0x400000>;
> I think you made this 0x200000 too small, unless there
> is supposed to be functional change.
>
> Konrad
> >                       no-map;
> >               };
> >       };