linux-kernel - Re: [PATCH 2/4] swiotlb: Add a new cc-swiotlb implementation for Confidential VMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bde64a70-7d9c-9e85-cd02-0301d4a0838e@linux.alibaba.com>
Date:   Sun, 29 Jan 2023 09:54:30 +0800
From:   Guorui Yu <GuoRui.Yu@...ux.alibaba.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
        iommu@...ts.linux-foundation.org, konrad.wilk@...cle.com,
        linux-coco@...ts.linux.dev
Cc:     robin.murphy@....com
Subject: Re: [PATCH 2/4] swiotlb: Add a new cc-swiotlb implementation for
 Confidential VMs

Hi Randy,

在 2023/1/29 00:41, Randy Dunlap 写道:
> Hi--
> 
> On 1/28/23 00:32, GuoRui.Yu wrote:
>> diff --git a/kernel/dma/Kconfig b/kernel/dma/Kconfig
>> index 56866aaa2ae1..7e6b20d2091f 100644
>> --- a/kernel/dma/Kconfig
>> +++ b/kernel/dma/Kconfig
>> @@ -78,8 +78,18 @@ config ARCH_HAS_FORCE_DMA_UNENCRYPTED
>>   
>>   config SWIOTLB
>>   	bool
>> +	depends on !CC_SWIOTLB
>>   	select NEED_DMA_MAP_STATE
>>   
>> +config CC_SWIOTLB
>> +	bool "Enable cc-swiotlb for Confidential VMs"
>> +	default n
>> +	select NEED_DMA_MAP_STATE
>> +	help
>> +	  This enables a cc-swiotlb implementation for Confidential VMs,
>> +	  which allows allocating the SWIOTLB buffer allocation on runtime.
> 
> Two "allocat..." words seems to be redundant. Probably the second one
> can be dropped.
> Also, instead of "on runtime", how about "at runtime"?

Thanks for your kindly advice, and I will fix it in the next version.

> 
>> +	  If unsure, say "n".
> 
> Thanks.

Sincerely,
Guorui