linux-kernel - Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <53AA669D-00F8-4F4B-A1BF-E81243DCF4DF@goldelico.com>
Date:   Sun, 29 Jan 2023 19:18:56 +0100
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Paul Cercueil <paul@...pouillou.net>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        周琰杰 <zhouyanjie@...yeetech.com>,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, letux-kernel@...nphoenux.org
Subject: Re: [PATCH] MIPS: DTS: CI20: fix otg power gpio

Hi Paul,

> Am 29.01.2023 um 19:08 schrieb Paul Cercueil <paul@...pouillou.net>:
> 
> Hi Nikolaus,
> 
> Le dimanche 29 janvier 2023 à 18:48 +0100, H. Nikolaus Schaller a
> écrit :
>> According to schematics it is PF15 and not PF14 (MIC_SW_EN).
>> Seems as if it was hidden and not noticed during testing since
>> there is no sound DT node.
>> 
>> Fixes: 158c774d3c64 ("MIPS: Ingenic: Add missing nodes for Ingenic
>> SoCs and boards.")
>> Signed-off-by: H. Nikolaus Schaller <hns@...delico.com>
> 
> Looking at the schematics it looks like you are correct. So:
> Acked-by: Paul Cercueil <paul@...pouillou.net>

Thanks!

> 
> I'm curious though, it is connected to the "SYS_POWER_IND" trace in the
> schematic, which seems to also switch the main led between red and
> blue, is that the case?

Yes, the LED changes between blue and red with this patch.

BR,
Nikolaus

> 
> Cheers,
> -Paul
> 
>> ---
>>  arch/mips/boot/dts/ingenic/ci20.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts
>> b/arch/mips/boot/dts/ingenic/ci20.dts
>> index 9819abb2465dd..a276488c0f752 100644
>> --- a/arch/mips/boot/dts/ingenic/ci20.dts
>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
>> @@ -115,7 +115,7 @@ otg_power: fixedregulator@2 {
>>                 regulator-min-microvolt = <5000000>;
>>                 regulator-max-microvolt = <5000000>;
>>  
>> -               gpio = <&gpf 14 GPIO_ACTIVE_LOW>;
>> +               gpio = <&gpf 15 GPIO_ACTIVE_LOW>;
>>                 enable-active-high;
>>         };
>>  };
>