lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <d4ae0db51f721234321d50aa8363cc061690a6d6.camel@linux.ibm.com> Date: Sun, 29 Jan 2023 20:07:00 +0100 From: Ilya Leoshkevich <iii@...ux.ibm.com> To: Tom Rix <trix@...hat.com>, zaslonko@...ux.ibm.com, akpm@...ux-foundation.org Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] lib/zlib: remove redundation assignement of avail_in dfltcc_gdht() On Sat, 2023-01-28 at 08:50 -0800, Tom Rix wrote: > cppcheck reports > lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment > of 'avail_in' to itself. [selfAssignment] > size_t avail_in = avail_in = strm->avail_in; > > Only setting avail_in once is needed. > > Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel > zlib_deflate") > Signed-off-by: Tom Rix <trix@...hat.com> > --- > lib/zlib_dfltcc/dfltcc_deflate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/zlib_dfltcc/dfltcc_deflate.c > b/lib/zlib_dfltcc/dfltcc_deflate.c > index 80924f067c24..b732b6d9e35d 100644 > --- a/lib/zlib_dfltcc/dfltcc_deflate.c > +++ b/lib/zlib_dfltcc/dfltcc_deflate.c > @@ -62,7 +62,7 @@ static void dfltcc_gdht( > { > deflate_state *state = (deflate_state *)strm->state; > struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param; > - size_t avail_in = avail_in = strm->avail_in; > + size_t avail_in = strm->avail_in; > > dfltcc(DFLTCC_GDHT, > param, NULL, NULL, Thanks for spotting this! Acked-by: Ilya Leoshkevich <iii@...ux.ibm.com>
Powered by blists - more mailing lists