lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230129033910.1327277-1-chenwandun@huawei.com>
Date:   Sun, 29 Jan 2023 11:39:10 +0800
From:   Chen Wandun <chenwandun@...wei.com>
To:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <ying.huang@...el.com>
CC:     <chenwandun@...wei.com>
Subject: [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios

migrate_hugetlbs returns -ENOMEM when no enough hugetlb,
however there may be free non-hugetlb folios available,
so continue to migrate for non-hugetlb folios.

Nowdays the only negtive return value of migrate_hugetlbs
is -ENOMEM, keep compatible for coming negtive return value
instead of ignore return value.

Signed-off-by: Chen Wandun <chenwandun@...wei.com>

---
v1 --> v2: modify changelog and comment. thanks Huang Ying.
---
 mm/migrate.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/mm/migrate.c b/mm/migrate.c
index b971edbf32fc..68927aa06f9b 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1939,7 +1939,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
 
 	rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private,
 				     mode, reason, &stats, &ret_folios);
-	if (rc_gather < 0)
+	/* There may be free non-hugetlb folios available, continue to migrate. */
+	if (rc_gather < 0 && rc_gather != -ENOMEM)
 		goto out;
 again:
 	nr_pages = 0;
-- 
2.25.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ