linux-kernel - Re: [PATCH] soc: sunxi: select CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Jan 2023 22:24:18 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Chen-Yu Tsai" <wens@...e.org>,
        "Samuel Holland" <samuel@...lland.org>,
        "Arnd Bergmann" <arnd@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] soc: sunxi: select CONFIG_PM

On Mon, Jan 30, 2023, at 22:18, Jernej Škrabec wrote:
> Dne ponedeljek, 30. januar 2023 ob 14:04:47 CET je Arnd Bergmann napisal(a):
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Selecting CONFIG_PM_GENERIC_DOMAINS without CONFIG_PM leads to a
>> build failure:
>> 
>> WARNING: unmet direct dependencies detected for PM_GENERIC_DOMAINS
>>   Depends on [n]: PM [=n]
>>   Selected by [y]:
>>   - SUN20I_PPU [=y] && (ARCH_SUNXI [=n] || COMPILE_TEST [=y])
>> 
>> drivers/base/power/domain_governor.c: In function 'default_suspend_ok':
>> drivers/base/power/domain_governor.c:85:24: error: 'struct dev_pm_info' has
>> no member named 'ignore_children' 85 |         if
>> (!dev->power.ignore_children)
>> 
>>       |                        ^
>> 
>> drivers/base/power/domain.c: In function 'genpd_queue_power_off_work':
>> drivers/base/power/domain.c:657:20: error: 'pm_wq' undeclared (first use in
>> this function) 657 |         queue_work(pm_wq, &genpd->power_off_work);
>> 
>>       |                    ^~~~~
>> 
>> Unfortunately platforms are inconsistent between using 'select PM'
>> and 'depends on PM' here. CONFIG_PM is a user-visible symbol, so
>> in principle we should be using 'depends on', but on the other hand
>> using 'select' here is more common among drivers/soc. Go with the
>> majority for now, as this has a smaller risk of introducing circular
>> dependencies. We may need to clean this up for consistency later.
>> 
>> Fixes: 0e30ca5ab0a8 ("soc: sunxi: Add Allwinner D1 PPU driver")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>
>
> Although, would it be better if commit in question is fixed and another PR is 
> issued? That way we can avoid issue with broken config.

Agreed, merging it into the original commit would have been ideal.
unfortunately the half of my brain that does the pull request
didn't talk to the half that wrote the bugfix, so I already pulled
it in after I sent the fix for linux-next...

I'll just add the fix with your Ack on top then.

    Arnd