lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <167511499566.3580584.7454212476889148702.robh@kernel.org> Date: Mon, 30 Jan 2023 15:43:19 -0600 From: Rob Herring <robh@...nel.org> To: Mark Brown <broonie@...nel.org> Cc: Frank Rowand <frowand.list@...il.com>, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org, 993612@...s.debian.org, Luca Di Stefano <luca.distefano@...aro.org>, stable@...nel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2] of/address: Return an error when no valid dma-ranges are found On Sat, 28 Jan 2023 17:47:50 +0000, Mark Brown wrote: > Commit 7a8b64d17e35 ("of/address: use range parser for of_dma_get_range") > converted the parsing of dma-range properties to use code shared with the > PCI range parser. The intent was to introduce no functional changes however > in the case where we fail to translate the first resource instead of > returning -EINVAL the new code we return 0. Restore the previous behaviour > by returning an error if we find no valid ranges, the original code only > handled the first range but subsequently support for parsing all supplied > ranges was added. > > This avoids confusing code using the parsed ranges which doesn't expect to > successfully parse ranges but have only a list terminator returned, this > fixes breakage with so far as I can tell all DMA for on SoC devices on the > Socionext Synquacer platform which has a firmware supplied DT. A bisect > identified the original conversion as triggering the issues there. > > Fixes: 7a8b64d17e35 ("of/address: use range parser for of_dma_get_range") > Signed-off-by: Mark Brown <broonie@...nel.org> > Cc: Luca Di Stefano <luca.distefano@...aro.org> > Cc: 993612@...s.debian.org > Cc: stable@...nel.org > --- > Changes in v2: > - Don't leak parsed resources. > - Link to v1: https://lore.kernel.org/r/20230126-synquacer-boot-v1-1-94ed0eb1011f@kernel.org > --- > drivers/of/address.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > Applied, thanks!
Powered by blists - more mailing lists