linux-kernel - Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230130224412.GA3658652-robh@kernel.org>
Date:   Mon, 30 Jan 2023 16:44:12 -0600
From:   Rob Herring <robh@...nel.org>
To:     Hermes Zhang <chenhuiz@...s.com>
Cc:     Ulf Hansson <ulf.hansson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        kernel@...s.com, linux-mmc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Is that a kernel feature or something from the MMC or SD specifications? 
The former doesn't belong in DT. Set this based on the compatible string 
of the controller.

> 
> Signed-off-by: Hermes Zhang <chenhuiz@...s.com>
> ---
> 
> Notes:
>     Update commit message
> 
>  Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
>      description:
>        enable SDIO IRQ signalling on this interface
>  
> +  cap-aggressive-pm:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      enable MMC_CAP_AGGRESSIVE_PM feature
> +
>    full-pwr-cycle:
>      $ref: /schemas/types.yaml#/definitions/flag
>      description:
> -- 
> 2.30.2
>