| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e620862840bcac9dcd46dd63e247966424af060f.camel@redhat.com>
Date: Mon, 30 Jan 2023 18:10:33 -0500
From: Lyude Paul <lyude@...hat.com>
To: Pin-yen Lin <treapking@...omium.org>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Neil Armstrong <neil.armstrong@...aro.org>,
Robert Foss <robert.foss@...aro.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
Daniel Scally <djrscally@...il.com>,
Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
"Rafael J . Wysocki" <rafael@...nel.org>,
Prashant Malani <pmalani@...omium.org>,
Benson Leung <bleung@...omium.org>,
Guenter Roeck <groeck@...omium.org>
Cc: Hsin-Yi Wang <hsinyi@...omium.org>,
dri-devel@...ts.freedesktop.org, Marek Vasut <marex@...x.de>,
Stephen Boyd <swboyd@...omium.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>,
Xin Ji <xji@...logixsemi.com>, linux-acpi@...r.kernel.org,
devicetree@...r.kernel.org, chrome-platform@...ts.linux.dev,
Thomas Zimmermann <tzimmermann@...e.de>,
Allen Chen <allen.chen@....com.tw>,
Javier Martinez Canillas <javierm@...hat.com>,
Nícolas "F . R . A . Prado"
<nfraprado@...labora.com>, linux-kernel@...r.kernel.org,
Douglas Anderson <dianders@...omium.org>,
Imre Deak <imre.deak@...el.com>,
Jani Nikula <jani.nikula@...el.com>,
Jim Cromie <jim.cromie@...il.com>,
Kees Cook <keescook@...omium.org>,
Uwe Kleine-König
<u.kleine-koenig@...gutronix.de>,
Ville Syrjälä
<ville.syrjala@...ux.intel.com>
Subject: Re: [PATCH v9 0/9] Register Type-C mode-switch in DP bridge
endpoints
Don't know if this still needs reviews from me (feel free to respond if it
does!), but I wanted to say nice work! This is something I've wanted to see
added to DRM for a while ♥
On Mon, 2023-01-09 at 16:40 +0800, Pin-yen Lin wrote:
> This series introduces bindings for anx7625/it6505 to register Type-C
> mode-switch in their output endpoints, and use data-lanes property to
> describe the pin connections.
>
> The first two patch modifies fwnode_graph_devcon_matches and
> cros_typec_init_ports to enable the registration of the switches.
>
> Patch 4~6 introduce the bindings for anx7625 and the corresponding driver
> modifications.
>
> Patch 7~9 add similar bindings and driver changes for it6505.
>
> v7: https://lore.kernel.org/all/20230105132457.4125372-1-treapking@chromium.org/
> v6: https://lore.kernel.org/all/20221124102056.393220-1-treapking@chromium.org/
> v5: https://lore.kernel.org/linux-usb/20220622173605.1168416-1-pmalani@chromium.org/
>
> Changes in v9:
> - Collected Reviewed-by tag
> - Fixed subject prefix again
> - Changed the naming of the example node for it6505
>
> Changes in v8:
> - Fixed the build issue when CONFIG_TYPEC=m
> - Fixed some style issues
> - Fixed the subject prefixes for the bindings patch
> - Fixed the bindings for data-lanes properties
>
> Changes in v7:
> - Fix the long comment lines
> - Extracted the common codes to a helper function
> - Fixed style issues in anx7625 driver
> - Removed DT property validation in anx7625 driver.
> - Fixed style issues in it6505 driver
> - Removed the redundant sleep in it6505 driver
> - Removed DT property validation in it6505 driver
> - Rebased to drm-misc-next
> - Fixed indentations in bindings patches
> - Added a new patch to fix indentations in Kconfig
>
> Changes in v6:
> - Changed it6505_typec_mux_set callback function to accommodate with
> the latest drm-misc patches
> - Changed the driver implementation to accommodate with the new binding
> - Dropped typec-switch binding and use endpoints and data-lanes properties
> to describe the pin connections
> - Added new patches (patch 1,2,4) to fix probing issues
> - Changed the bindings of it6505/anx7625 and modified the drivers
> accordingly
> - Merged it6505/anx7625 driver changes into a single patch
>
> Pin-yen Lin (7):
> drm/display: Add Type-C switch helpers
> dt-bindings: display: bridge: anx7625: Add mode-switch support
> drm/bridge: anx7625: Check for Type-C during panel registration
> drm/bridge: anx7625: Register Type C mode switches
> dt-bindings: display: bridge: it6505: Add mode-switch support
> drm/bridge: it6505: Fix Kconfig indentation
> drm/bridge: it6505: Register Type C mode switches
>
> Prashant Malani (2):
> device property: Add remote endpoint to devcon matcher
> platform/chrome: cros_ec_typec: Purge blocking switch devlinks
>
> .../display/bridge/analogix,anx7625.yaml | 99 ++++++++++++-
> .../bindings/display/bridge/ite,it6505.yaml | 93 ++++++++++--
> drivers/base/property.c | 15 ++
> drivers/gpu/drm/bridge/Kconfig | 21 +--
> drivers/gpu/drm/bridge/analogix/Kconfig | 1 +
> drivers/gpu/drm/bridge/analogix/anx7625.c | 101 +++++++++++++-
> drivers/gpu/drm/bridge/analogix/anx7625.h | 13 ++
> drivers/gpu/drm/bridge/ite-it6505.c | 119 +++++++++++++++-
> drivers/gpu/drm/display/drm_dp_helper.c | 132 ++++++++++++++++++
> drivers/platform/chrome/cros_ec_typec.c | 10 ++
> include/drm/display/drm_dp_helper.h | 16 +++
> 11 files changed, 591 insertions(+), 29 deletions(-)
>
--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat
Powered by blists - more mailing lists