linux-kernel - Re: [RFC PATCH v6 5/6] KVM: x86: add vCPU scoped toggling for disabled exits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y9dmwQNS1qufVwYZ@gao-cwp>
Date:   Mon, 30 Jan 2023 14:42:09 +0800
From:   Chao Gao <chao.gao@...el.com>
To:     Kechen Lu <kechenl@...dia.com>
CC:     <kvm@...r.kernel.org>, <seanjc@...gle.com>, <pbonzini@...hat.com>,
        <zhi.wang.linux@...il.com>, <shaoqin.huang@...el.com>,
        <vkuznets@...hat.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH v6 5/6] KVM: x86: add vCPU scoped toggling for
 disabled exits

On Sat, Jan 21, 2023 at 02:07:37AM +0000, Kechen Lu wrote:
>+static void svm_update_disabled_exits(struct kvm_vcpu *vcpu)

Is it possible to call this function on vCPU creation, i.e., consolidate
initialization and runtime toggling?

>+{
>+	struct vcpu_svm *svm = to_svm(vcpu);
>+	struct vmcb_control_area *control = &svm->vmcb->control;
>+
>+	if (kvm_hlt_in_guest(vcpu))
>+		svm_clr_intercept(svm, INTERCEPT_HLT);
>+	else
>+		svm_set_intercept(svm, INTERCEPT_HLT);
>+
>+	if (kvm_mwait_in_guest(vcpu)) {
>+		svm_clr_intercept(svm, INTERCEPT_MONITOR);
>+		svm_clr_intercept(svm, INTERCEPT_MWAIT);
>+	} else {
>+		svm_set_intercept(svm, INTERCEPT_MONITOR);
>+		svm_set_intercept(svm, INTERCEPT_MWAIT);
>+	}
>+
>+	if (kvm_pause_in_guest(vcpu)) {
>+		svm_clr_intercept(svm, INTERCEPT_PAUSE);
>+	} else {
>+		control->pause_filter_count = pause_filter_count;
>+		if (pause_filter_thresh)
>+			control->pause_filter_thresh = pause_filter_thresh;
>+	}
>+}
>+
> static void svm_vm_destroy(struct kvm *kvm)
> {
> 	avic_vm_destroy(kvm);
>@@ -4825,7 +4852,10 @@ static struct kvm_x86_ops svm_x86_ops __initdata = {
> 	.complete_emulated_msr = svm_complete_emulated_msr,
> 
> 	.vcpu_deliver_sipi_vector = svm_vcpu_deliver_sipi_vector,
>+
> 	.vcpu_get_apicv_inhibit_reasons = avic_vcpu_get_apicv_inhibit_reasons,
>+
>+	.update_disabled_exits = svm_update_disabled_exits,
> };
> 
> /*
>diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>index 019a20029878..f5137afdd424 100644
>--- a/arch/x86/kvm/vmx/vmx.c
>+++ b/arch/x86/kvm/vmx/vmx.c
>@@ -8070,6 +8070,41 @@ static void vmx_vm_destroy(struct kvm *kvm)
> 	free_pages((unsigned long)kvm_vmx->pid_table, vmx_get_pid_table_order(kvm));
> }
> 
>+static void vmx_update_disabled_exits(struct kvm_vcpu *vcpu)

ditto.