linux-kernel - Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKYAXd-gKrZ4gZZjookTDSL9ATLtnapQrciJpFH=LzX_8-ZO9g@mail.gmail.com>
Date:   Mon, 30 Jan 2023 10:57:16 +0900
From:   Namjae Jeon <linkinjeon@...nel.org>
To:     Steve French <smfrench@...il.com>
Cc:     CIFS <linux-cifs@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][KSMBD] fix indentation in ksmbd config and note Kerberos support

2023-01-30 9:01 GMT+09:00, Steve French <smfrench@...il.com>:
Hi Steve,

> Fix indentation of server config options, and also since
> support for very old, less secure, NTLM authentication was removed
> (and quite a while ago), remove the mention of that in Kconfig, but
> do note Kerberos (not just NTLMv2) which are supported and much
> more secure.
>
> Signed-off-by: Steve French <stfrench@...rosoft.com>
> ---
>  fs/ksmbd/Kconfig | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ksmbd/Kconfig b/fs/ksmbd/Kconfig
> index e1fe17747ed6..4153e5491435 100644
> --- a/fs/ksmbd/Kconfig
> +++ b/fs/ksmbd/Kconfig
> @@ -33,17 +33,18 @@ config SMB_SERVER
>     in ksmbd-tools, available from
>     https://github.com/cifsd-team/ksmbd-tools.
>     More detail about how to run the ksmbd kernel server is
> -   available via README file
> +   available via the README file
>     (https://github.com/cifsd-team/ksmbd-tools/blob/master/README).
>
>     ksmbd kernel server includes support for auto-negotiation,
>     Secure negotiate, Pre-authentication integrity, oplock/lease,
>     compound requests, multi-credit, packet signing, RDMA(smbdirect),
>     smb3 encryption, copy-offload, secure per-user session
> -   establishment via NTLM or NTLMv2.
> +   establishment via Kerberos or NTLMv2.
>
>  config SMB_SERVER_SMBDIRECT
>   bool "Support for SMB Direct protocol"
> + depends on SMB_SERVER
I am wondering this change is needed in this patch ? There is no patch
description for this change...

Thanks!
>   depends on SMB_SERVER=m && INFINIBAND && INFINIBAND_ADDR_TRANS ||
> SMB_SERVER=y && INFINIBAND=y && INFINIBAND_ADDR_TRANS=y
>   select SG_POOL
>   default n
>
> --
> Thanks,
>
> Steve
>