linux-kernel - Re: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9eKwMoK4EyqfEMK@aptenodytes>
Date:   Mon, 30 Jan 2023 10:15:44 +0100
From:   Paul Kocialkowski <paul.kocialkowski@...tlin.com>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     dri-devel@...ts.freedesktop.org,
        LKML <linux-kernel@...r.kernel.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>
Subject: Re: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on
 COMPILE_TEST

Hi Jean,

On Fri 27 Jan 23, 12:01, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>

Sounds good to me!

Reviewed-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>

Cheers,

Paul

> ---
>  drivers/gpu/drm/logicvc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.1.orig/drivers/gpu/drm/logicvc/Kconfig
> +++ linux-6.1/drivers/gpu/drm/logicvc/Kconfig
> @@ -1,7 +1,7 @@
>  config DRM_LOGICVC
>  	tristate "LogiCVC DRM"
>  	depends on DRM
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	select DRM_KMS_HELPER
>  	select DRM_KMS_DMA_HELPER
>  	select DRM_GEM_DMA_HELPER
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support

-- 
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)