linux-kernel - Re: [regression] Bug 216977 - asus t100 touchpad registered but not working

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325be2be-0c58-7414-70e9-9585e35874a2@redhat.com>
Date:   Mon, 30 Jan 2023 11:16:56 +0100
From:   Hans de Goede <hdegoede@...hat.com>
To:     Linux regressions mailing list <regressions@...ts.linux.dev>,
        Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <btissoir@...hat.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        jessegodfroy@...il.com
Subject: Re: [regression] Bug 216977 - asus t100 touchpad registered but not
 working

Hi All,

On 1/30/23 10:22, Linux kernel regression tracking (Thorsten Leemhuis) wrote:
> Hi, this is your Linux kernel regression tracker.
> 
> I noticed a regression report in bugzilla.kernel.org. As many (most?)
> kernel developer don't keep an eye on it, I decided to forward it by
> mail. Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=216977 :
> 
>>  jessegodfroy@...il.com 2023-01-29 15:44:34 UTC
>>
>> After upgrading the kernel from 6.0 series to the 6.1 the touchpad on my asus t100 no longer works. 
>>
>> The device is registered in dmesg. I believe hid_asus is responsible for the keyboard and touchpad.  The keyboard continues to function, but the touchpad does not. 
>>
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0001: input,hidraw0: USB HID v1.11 Keyboard [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input0
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: Fixing up Asus T100 keyb report descriptor
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0002: input,hiddev96,hidraw1: USB HID v1.11 Device [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input1
>> Jan 29 09:29:53 t100ta-white kernel: asus 0003:0B05:17E0.0003: input,hiddev97,hidraw2: USB HID v1.11 Mouse [ASUSTek COMPUTER INC. ASUS Base Station(T100)] on usb-0000:00:14.0-3/input2
>>
>> I do not see any changes to hid_asus that should be responsible for the change in performance.
> See the ticket for more details.

This is my bad, I accidentally broke SW_TABLET_MODE reporting on
the Asus T100* and T101* series and it is now reporting that it
is in tablet mode while it is actually docked and thus in laptop
mode.

This is causing libinput to suppress touchpad events, as
it would for a 360° hinges style 2 in 1 with the keyboard +
touchpad folded behind the display (so in tablet mode).

A fix for this has already been merged for 6.2-rc6:

"platform/x86: asus-wmi: Fix kbd_dock_devid tablet-switch reporting"
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=fdcc0602d64f22185f61c70747214b630049cc33

And the fix is also queued for the next 6.1.y stable series release:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/log/?h=queue/6.1

I'll also add this info as a comment to the bug.

Regards,

Hans