lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAGuA+opQboxH8qoNv4GG+raX=ZZAyRVLC9VLjVCzbT_cUQWWTA@mail.gmail.com> Date: Mon, 30 Jan 2023 11:40:03 +0100 From: Balsam CHIHI <bchihi@...libre.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> Cc: daniel.lezcano@...aro.org, angelogioacchino.delregno@...labora.com, rafael@...nel.org, amitk@...nel.org, rui.zhang@...el.com, matthias.bgg@...il.com, robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, rdunlap@...radead.org, ye.xingchen@....com.cn, p.zabel@...gutronix.de, linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, devicetree@...r.kernel.org, khilman@...libre.com, james.lo@...iatek.com, rex-bc.chen@...iatek.com Subject: Re: [PATCH v12 2/6] dt-bindings: thermal: mediatek: Add LVTS thermal controllers dt-binding definition Hi Krzysztof, Thank you for the feedback. On Sat, Jan 28, 2023 at 11:48 AM Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote: > > On 26/01/2023 17:10, bchihi@...libre.com wrote: > > From: Balsam CHIHI <bchihi@...libre.com> > > > > Add LVTS thermal controllers dt-binding definition for mt8195. > > Subject: drop second/last, redundant "dt-binding definition". The > "dt-bindings" prefix is already stating that these are bindings. fixed. The patch title has been fixed as you suggested : "dt-bindings: thermal: mediatek: Add LVTS thermal controllers" > > Plus two comments at the end. > > > > > Signed-off-by: Balsam CHIHI <bchihi@...libre.com> > > --- > > Changelog: > > v12: > > - Fixed subject prefix > > - Fixed licences GPL-2.0+ to GPL-2.0 > > - Added dual licenses > > > > + }; > > diff --git a/include/dt-bindings/thermal/mediatek-lvts.h b/include/dt-bindings/thermal/mediatek-lvts.h > > new file mode 100644 > > index 000000000000..902d5b1e4f43 > > --- /dev/null > > +++ b/include/dt-bindings/thermal/mediatek-lvts.h > > Same filename as bindings. fixed. rename : include/dt-bindings/thermal/mediatek-lvts.h => include/dt-bindings/thermal/mediatek-lvts-thermal.h > > > @@ -0,0 +1,19 @@ > > +/* SPDX-License-Identifier: (GPL-2.0 or MIT) */ > > Although this is correct, any reason why not using exactly the same > license as bindings? fixed. both files are now using the same license : "SPDX-License-Identifier: (GPL-2.0 or MIT)" > > > +/* > > + * Copyright (c) 2023 MediaTek Inc. > > + * Author: Balsam CHIHI <bchihi@...libre.com> > > + */ > > Best regards, > Krzysztof > I'll send the changes soon. Best regards, Balsam
Powered by blists - more mailing lists