[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y9cn4NYvI6+XW302@leoy-yangtze.lan>
Date: Mon, 30 Jan 2023 10:13:52 +0800
From: Leo Yan <leo.yan@...aro.org>
To: Rob Herring <robh@...nel.org>
Cc: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
James Clark <james.clark@....com>,
Will Deacon <will@...nel.org>,
linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf arm-spe: Only warn once for each unsupported
address packet
On Fri, Jan 27, 2023 at 02:55:46PM -0600, Rob Herring wrote:
> Unknown address packet indexes are not an error as the Arm architecture
> can (and has with SPEv1.2) define new ones and implementation defined
> ones are also allowed. The error message for every occurrence of the
> packet is needlessly noisy as well. Change the message to print just
> once for each unknown index.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
Reviewed-by: Leo Yan <leo.yan@...aro.org>
> ---
> tools/perf/util/arm-spe-decoder/arm-spe-decoder.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> index 091987dd3966..40dcedfd75cd 100644
> --- a/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> +++ b/tools/perf/util/arm-spe-decoder/arm-spe-decoder.c
> @@ -68,7 +68,11 @@ static u64 arm_spe_calc_ip(int index, u64 payload)
> /* Clean highest byte */
> payload = SPE_ADDR_PKT_ADDR_GET_BYTES_0_6(payload);
> } else {
> - pr_err("unsupported address packet index: 0x%x\n", index);
> + static u32 seen_idx = 0;
> + if (!(seen_idx & BIT(index))) {
> + seen_idx |= BIT(index);
> + pr_warning("ignoring unsupported address packet index: 0x%x\n", index);
> + }
> }
>
> return payload;
> --
> 2.39.0
>
Powered by blists - more mailing lists