linux-kernel - Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9e12m28aOMlTs0c@smile.fi.intel.com>
Date:   Mon, 30 Jan 2023 14:19:38 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     ye.xingchen@....com.cn
Cc:     dmitry.torokhov@...il.com, jonathan.cameron@...wei.com,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

On Sat, Jan 28, 2023 at 04:11:30PM +0800, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

...

> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> +	keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

Why?

What we need here is simple devm_platform_ioremap_resource().

-- 
With Best Regards,
Andy Shevchenko