linux-kernel - Re: [PATCH] sched/fair: sanitize vruntime of entity being placed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y9fC+W8eah73WWP8@chenyu5-mobl1>
Date:   Mon, 30 Jan 2023 21:15:37 +0800
From:   Chen Yu <yu.c.chen@...el.com>
To:     Zhang Qiao <zhangqiao22@...wei.com>
CC:     <linux-kernel@...r.kernel.org>, Roman Kagan <rkagan@...zon.de>,
        "Daniel Bristot de Oliveira" <bristot@...hat.com>,
        Ben Segall <bsegall@...gle.com>,
        Ingo Molnar <mingo@...hat.com>,
        Waiman Long <longman@...hat.com>,
        "Dietmar Eggemann" <dietmar.eggemann@....com>,
        Peter Zijlstra <peterz@...radead.org>,
        Valentin Schneider <vschneid@...hat.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        "Mel Gorman" <mgorman@...e.de>, Juri Lelli <juri.lelli@...hat.com>
Subject: Re: [PATCH] sched/fair: sanitize vruntime of entity being placed

On 2023-01-29 at 09:27:07 +0800, Zhang Qiao wrote:
> Hi, Chenyu,
> 
> On 2023/1/29 1:27, Chen Yu wrote:
> > Hi Roman, Qiao,
> > On 2023-01-27 at 17:32:30 +0100, Roman Kagan wrote:
> >> From: Zhang Qiao <zhangqiao22@...wei.com>
[snip]
> > If I understand correctly, se->exec_start is just updated by enqueue_entity()->update_curr(cfs_rq),
> 
> When a task go to sleep, se->exec_start will update at dequeue_entity()->update_curr(cfs_rq).
> And enqueue_entity()->update_curr(cfs_rq) just update current se.
>
You are right. update_curr(cfs_rq) only updates the current running one and the se
has not been queued yet.

thanks,
Chenyu