linux-kernel - Re: [PATCH v3 4/4] power: supply: Introduce Qualcomm PMIC GLINK power supply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ace1821-1892-ace5-c230-34200119cc55@linaro.org>
Date:   Mon, 30 Jan 2023 15:30:11 +0100
From:   Neil Armstrong <neil.armstrong@...aro.org>
To:     Bjorn Andersson <quic_bjorande@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sebastian Reichel <sre@...nel.org>
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        Subbaraman Narayanamurthy <quic_subbaram@...cinc.com>,
        Johan Hovold <johan@...nel.org>
Subject: Re: [PATCH v3 4/4] power: supply: Introduce Qualcomm PMIC GLINK power
 supply

On 30/01/2023 05:20, Bjorn Andersson wrote:
> From: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> The PMIC GLINK service, running on a coprocessor of modern Qualcomm
> platforms, deals with battery charging and fuel gauging, as well as
> reporting status of AC and wireless power supplies.
> 
> As this is just one of the functionalities provided by the PMIC GLINK
> service, this power supply driver is implemented as an auxilirary bus
> driver, spawned by the main "pmic glink" driver when the PMIC GLINK
> service is detected.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> Tested-by: Konrad Dybcio <konrad.dybcio@...aro.org> # SM8350 PDX215
> Signed-off-by: Bjorn Andersson <quic_bjorande@...cinc.com>
> ---
> 
> Changes since v2:
> - None
> 
>   drivers/power/supply/Kconfig        |    9 +
>   drivers/power/supply/Makefile       |    1 +
>   drivers/power/supply/qcom_battmgr.c | 1421 +++++++++++++++++++++++++++
>   3 files changed, 1431 insertions(+)
>   create mode 100644 drivers/power/supply/qcom_battmgr.c
> 

<snip>


Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>

Devices doesn't have a battery, but it behaved as expected and values were coherent:
Tested-by: Neil Armstrong <neil.armstrong@...aro.org> # on SM8550-MTP & SM8450-HDK