linux-kernel - Re: [PATCH v2] powerpc: macio: Make remove callback of macio driver void returned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <TYCP286MB2323A8880DE1D1EDFCF58F05CAD39@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM>
Date:   Mon, 30 Jan 2023 22:39:03 +0800
From:   Dawei Li <set_pte_at@...look.com>
To:     Michael Ellerman <mpe@...erman.id.au>
Cc:     npiggin@...il.com, christophe.leroy@...roup.eu,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] powerpc: macio: Make remove callback of macio driver
 void returned

Hi Michael,

Thanks for reviewing,

On Mon, Jan 30, 2023 at 03:47:55PM +1100, Michael Ellerman wrote:
> Dawei Li <set_pte_at@...look.com> writes:
> > Commit fc7a6209d571 ("bus: Make remove callback return void") forces
> > bus_type::remove be void-returned, it doesn't make much sense for any
> > bus based driver implementing remove callbalk to return non-void to
> > its caller.
> >
> > This change is for macio bus based drivers.
> >
> > Signed-off-by: Dawei Li <set_pte_at@...look.com>
> > ---
> > v1 -> v2
> > - Revert unneeded changes.
> > - Rebased on latest powerpc/next.
> >
> > v1
> > - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/
> > ---
> >  arch/powerpc/include/asm/macio.h                | 2 +-
> >  drivers/ata/pata_macio.c                        | 4 +---
> >  drivers/macintosh/rack-meter.c                  | 4 +---
> >  drivers/net/ethernet/apple/bmac.c               | 4 +---
> >  drivers/net/ethernet/apple/mace.c               | 4 +---
> >  drivers/net/wireless/intersil/orinoco/airport.c | 4 +---
> >  drivers/scsi/mac53c94.c                         | 5 +----
> >  drivers/scsi/mesh.c                             | 5 +----
> >  drivers/tty/serial/pmac_zilog.c                 | 7 ++-----
> >  sound/aoa/soundbus/i2sbus/core.c                | 4 +---
> >  10 files changed, 11 insertions(+), 32 deletions(-)
> 
> I realise the patch has to be merged via a single subsystem, and powerpc
> is probably the most appropriate, but please Cc the relevant lists for
> the drivers touched.

Copy that. Relevant lists will be cc'ed in v3.

Thanks,
        Dawei 
> 
> AFAICS neither this version or v1 was Cc'ed to relevant lists, eg.
> netdev, linux-wireless, linux-scsi, alsa-devel etc.
> 
> cheers