linux-kernel - Re: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABVgOSnRC3AuUo4Qc2K3pXEcj3Wbt9LE2DTbejGrPOCKefxB2g@mail.gmail.com>
Date:   Tue, 31 Jan 2023 08:00:40 +0800
From:   David Gow <davidgow@...gle.com>
To:     Masahiro Yamada <masahiroy@...nel.org>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
        Brendan Higgins <brendanhiggins@...gle.com>
Subject: Re: [PATCH v1 1/1] .gitignore: Unignore .kunitconfig

On Sat, 28 Jan 2023 at 22:37, Masahiro Yamada <masahiroy@...nel.org> wrote:
>
> On Sat, Jan 28, 2023 at 3:56 PM David Gow <davidgow@...gle.com> wrote:
> >
> > On Fri, 27 Jan 2023 at 22:56, Andy Shevchenko
> > <andriy.shevchenko@...ux.intel.com> wrote:
> > >
> > > There are almost dozen of .kunitconfig files that are ignored but
> > > tracked. Unignore them.
> > >
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > ---
> >
> > Thanks! Only the original root-directory .kunitignore file was
> > intended to be ignored, and that's no longer as important, and is now
> > in the build dir anyway.
> >
> > Reviewed-by: David Gow <davidgow@...gle.com>
> >
> > Cheers,
> > -- David
> >
> > >  .gitignore | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/.gitignore b/.gitignore
> > > index 22984d22d29e..e4f2ba0be516 100644
> > > --- a/.gitignore
> > > +++ b/.gitignore
> > > @@ -100,6 +100,7 @@ modules.order
> > >  !.get_maintainer.ignore
> > >  !.gitattributes
> > >  !.gitignore
> > > +!.kunitconfig
> > >  !.mailmap
> > >  !.rustfmt.toml
> > >
> > > --
> > > 2.39.0
> > >
>
>
> Why is this a dot file in the first place?
>

In short, historical reasons.

The long answer is that there are two places "kunitconfig" files are
used: as a user-provided file with their preferred test config (which
is kept local), and as a recommended test config for a given subsystem
(which is checked in).
Originally, no .kunitconfig files were checked in: one was either
autogenerated or manually modified and left in the root source
directory. This eventually moved into the build directory, and a
number of features which de-emphasized it in favour of command-line
arguments and the (new) checked-in per-subsystem configs, which
probably shouldn't be hidden.

There's no fundamental reason (other than it being a bit annoying to
rename everything and update the code) we can't change it, either for
all kunitconfig files, or just the checked-in ones, if that's
preferred.

-- David

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4003 bytes)