linux-kernel - Re: [PATCH] tracing: Fix wrong return in kprobe_event_gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 10:13:00 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Anton Gusev <aagusev@...ras.ru>
Cc:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, linux-trace-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: Fix wrong return in kprobe_event_gen_test.c

On Tue, 31 Jan 2023 10:58:18 +0300
Anton Gusev <aagusev@...ras.ru> wrote:

> Overwriting the error code with the deletion result may cause the
> function to return 0 despite encountering an error. Commit b111545d26c0
> ("tracing: Remove the useless value assignment in
> test_create_synth_event()") solves a similar issue by
> returning the original error code, so this patch does the same.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Anton Gusev <aagusev@...ras.ru>

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

Thanks Anton!

-- Steve