linux-kernel - Re: [PATCH v5 03/25] powerpc/secvar: Fix incorrect return in secvar_sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1f633865-d695-467a-b240-135c4887329b@linux.ibm.com>
Date:   Tue, 31 Jan 2023 10:18:15 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Andrew Donnellan <ajd@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-integrity@...r.kernel.org
Cc:     ruscur@...sell.cc, bgray@...ux.ibm.com, nayna@...ux.ibm.com,
        gcwilson@...ux.ibm.com, gjoyce@...ux.ibm.com, brking@...ux.ibm.com,
        sudhakar@...ux.ibm.com, erichte@...ux.ibm.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        zohar@...ux.ibm.com, joel@....id.au, npiggin@...il.com
Subject: Re: [PATCH v5 03/25] powerpc/secvar: Fix incorrect return in
 secvar_sysfs_load()



On 1/31/23 01:39, Andrew Donnellan wrote:
> From: Russell Currey <ruscur@...sell.cc>
> 
> secvar_ops->get_next() returns -ENOENT when there are no more variables
> to return, which is expected behaviour.
> 
> Fix this by returning 0 if get_next() returns -ENOENT.
> 
> This fixes an issue introduced in commit bd5d9c743d38 ("powerpc: expose
> secure variables to userspace via sysfs"), but the return code of
> secvar_sysfs_load() was never checked so this issue never mattered.
> 
> Signed-off-by: Russell Currey <ruscur@...sell.cc>
> Signed-off-by: Andrew Donnellan <ajd@...ux.ibm.com>
> 
> ---
> 
> v5: New patch
> ---
>   arch/powerpc/kernel/secvar-sysfs.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
> index 1ee4640a2641..7fa5f8ed9542 100644
> --- a/arch/powerpc/kernel/secvar-sysfs.c
> +++ b/arch/powerpc/kernel/secvar-sysfs.c
> @@ -179,8 +179,10 @@ static int secvar_sysfs_load(void)
>   		rc = secvar_ops->get_next(name, &namesize, NAME_MAX_SIZE);
>   		if (rc) {
>   			if (rc != -ENOENT)
> -				pr_err("error getting secvar from firmware %d\n",
> -				       rc);
> +				pr_err("error getting secvar from firmware %d\n", rc);
> +			else
> +				rc = 0;
> +
>   			break;
>   		}
>   

Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>