linux-kernel - Re: [PATCH v5 13/25] powerpc/secvar: Don't print error on ENOENT when reading variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <06cb4327-5e60-d472-57cc-3b2c568014f1@linux.ibm.com>
Date:   Tue, 31 Jan 2023 10:58:30 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Andrew Donnellan <ajd@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-integrity@...r.kernel.org
Cc:     ruscur@...sell.cc, bgray@...ux.ibm.com, nayna@...ux.ibm.com,
        gcwilson@...ux.ibm.com, gjoyce@...ux.ibm.com, brking@...ux.ibm.com,
        sudhakar@...ux.ibm.com, erichte@...ux.ibm.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        zohar@...ux.ibm.com, joel@....id.au, npiggin@...il.com
Subject: Re: [PATCH v5 13/25] powerpc/secvar: Don't print error on ENOENT when
 reading variables



On 1/31/23 01:39, Andrew Donnellan wrote:
> If attempting to read the size or data attributes of a  non-existent
> variable (which will be possible after a later patch to expose the PLPKS
> via the secvar interface), don't spam the kernel log with error messages.
> Only print errors for return codes that aren't ENOENT.
> 
> Reported-by: Sudhakar Kuppusamy <sudhakar@...ux.ibm.com>
> Signed-off-by: Andrew Donnellan <ajd@...ux.ibm.com>

Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>

> 
> ---
> 
> v3: New patch
> ---
>   arch/powerpc/kernel/secvar-sysfs.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/secvar-sysfs.c b/arch/powerpc/kernel/secvar-sysfs.c
> index 9b6be63b7b36..ca3df3f7156c 100644
> --- a/arch/powerpc/kernel/secvar-sysfs.c
> +++ b/arch/powerpc/kernel/secvar-sysfs.c
> @@ -43,8 +43,8 @@ static ssize_t size_show(struct kobject *kobj, struct kobj_attribute *attr,
>   
>   	rc = secvar_ops->get(kobj->name, strlen(kobj->name) + 1, NULL, &dsize);
>   	if (rc) {
> -		pr_err("Error retrieving %s variable size %d\n", kobj->name,
> -		       rc);
> +		if (rc != -ENOENT)
> +			pr_err("Error retrieving %s variable size %d\n", kobj->name, rc);
>   		return rc;
>   	}
>   
> @@ -61,7 +61,8 @@ static ssize_t data_read(struct file *filep, struct kobject *kobj,
>   
>   	rc = secvar_ops->get(kobj->name, strlen(kobj->name) + 1, NULL, &dsize);
>   	if (rc) {
> -		pr_err("Error getting %s variable size %d\n", kobj->name, rc);
> +		if (rc != -ENOENT)
> +			pr_err("Error getting %s variable size %d\n", kobj->name, rc);
>   		return rc;
>   	}
>   	pr_debug("dsize is %llu\n", dsize);