linux-kernel - Re: [PATCH v5 18/25] powerpc/pseries: Log hcall return codes for PLPKS debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7e3df6a-c62b-c22c-119a-a4f14662ca0c@linux.ibm.com>
Date:   Tue, 31 Jan 2023 11:31:22 -0500
From:   Stefan Berger <stefanb@...ux.ibm.com>
To:     Andrew Donnellan <ajd@...ux.ibm.com>,
        linuxppc-dev@...ts.ozlabs.org, linux-integrity@...r.kernel.org
Cc:     ruscur@...sell.cc, bgray@...ux.ibm.com, nayna@...ux.ibm.com,
        gcwilson@...ux.ibm.com, gjoyce@...ux.ibm.com, brking@...ux.ibm.com,
        sudhakar@...ux.ibm.com, erichte@...ux.ibm.com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        zohar@...ux.ibm.com, joel@....id.au, npiggin@...il.com
Subject: Re: [PATCH v5 18/25] powerpc/pseries: Log hcall return codes for
 PLPKS debug



On 1/31/23 01:39, Andrew Donnellan wrote:
> From: Russell Currey <ruscur@...sell.cc>
> 
> The plpks code converts hypervisor return codes into their Linux
> equivalents so that users can understand them.  Having access to the
> original return codes is really useful for debugging, so add a
> pr_debug() so we don't lose information from the conversion.
> 
> Signed-off-by: Russell Currey <ruscur@...sell.cc>
> Signed-off-by: Andrew Donnellan <ajd@...ux.ibm.com>

Reviewed-by: Stefan Berger <stefanb@...ux.ibm.com>

> ---
>   arch/powerpc/platforms/pseries/plpks.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/powerpc/platforms/pseries/plpks.c b/arch/powerpc/platforms/pseries/plpks.c
> index cee06fb9a370..e5755443d4a4 100644
> --- a/arch/powerpc/platforms/pseries/plpks.c
> +++ b/arch/powerpc/platforms/pseries/plpks.c
> @@ -117,6 +117,8 @@ static int pseries_status_to_err(int rc)
>   		err = -EINVAL;
>   	}
>   
> +	pr_debug("Converted hypervisor code %d to Linux %d\n", rc, err);
> +
>   	return err;
>   }
>