linux-kernel - Aw: Re: [PATCH 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jan 2023 17:39:49 +0100
From:   Frank Wunderlich <frank-w@...lic-files.de>
To:     Matthias Brugger <matthias.bgg@...il.com>
Cc:     Arınç ÜNAL <arinc.unal@...nc9.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        erkin.bozoglu@...ont.com, Sean Wang <sean.wang@...iatek.com>,
        DENG Qingfang <dqfext@...il.com>
Subject: Aw: Re: [PATCH 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2

Hi
> Gesendet: Dienstag, 31. Januar 2023 um 12:55 Uhr
> Von: "Matthias Brugger" <matthias.bgg@...il.com>
> An: "Arınç ÜNAL" <arinc.unal@...nc9.com>, frank-w@...lic-files.de, "Rob Herring" <robh+dt@...nel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>
> Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, erkin.bozoglu@...ont.com, "Sean Wang" <sean.wang@...iatek.com>, "DENG Qingfang" <dqfext@...il.com>
> Betreff: Re: [PATCH 4/5] arm: dts: mt7623: mux phy0 on Bananapi BPI-R2
>
> 
> 
> On 25/01/2023 17:54, Arınç ÜNAL wrote:
> > On 25.01.2023 19:41, Frank Wunderlich wrote:
> >> Am 20. Januar 2023 21:53:17 MEZ schrieb "Arınç ÜNAL" <arinc.unal@...nc9.com>:
> >>
> >>>         switch@1f {
> >>>             compatible = "mediatek,mt7530";
> >>>             reg = <0x1f>;
> >>> @@ -199,11 +208,6 @@ ports {
> >>>                 #address-cells = <1>;
> >>>                 #size-cells = <0>;
> >>>
> >>> -                port@0 {
> >>> -                    reg = <0>;
> >>> -                    label = "wan";
> >>> -                };
> >>> -
> >>
> >> This will break existing userspace setups using wan as interface name.
> > 
> > Yup. The OS being used will have to either rename the interface or adapt to the 
> > new name, eth1.
> > 
> 
> In that case please explain in the commit message why this is needed. We are 
> trying really hard to not break userspace by a device-tree update.

I understand the reason why Arınç wants to change it:

currently all ports including wan-port are routed via dsa over gmac0 (trgmii), Arınç enables the second gmac and port5 of switch to route wan-traffic over the other gmac. But unfortunately there is no mainline-way to rename the gmac1 interface (eth1) to wan...this would be a way to not break the userspace.

i had an older patch for mtk_eth_soc [1] which do it at driver level for mediatek ethernet driver, but afair a generic way to (re)name interfaces in dts (vendor independ) was requested as the right way.

regards Frank

[1] https://github.com/frank-w/BPI-Router-Linux/commit/5088c9c81e90014622a950fca38cfb29e0421155